Handle blank poll options more gracefully #10946
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be equally simple to add a |
ClearlyClaire
force-pushed
the
fixes/poll-empty-option
branch
from
7dc956b
to
d30241e
Compare
Pleroma currently allows (erroneously imho) empty poll options, that is, options with an empty (but existing) `name`.
ClearlyClaire
force-pushed
the
fixes/poll-empty-option
branch
from
d30241e
to
f67fc06
Compare
|
I guess so. |
Gargron
approved these changes
Jun 3, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Pleroma currently allows (erroneously imho) empty poll options, that is, options with an empty (but existing) `name`.
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jan 7, 2021
Pleroma currently allows (erroneously imho) empty poll options, that is, options with an empty (but existing) `name`.
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Pleroma currently allows (erroneously imho) empty poll options, that is, options with an empty (but existing) `name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pleroma currently allows (erroneously imho) empty poll options, that is,
options with an empty (but existing)
name.In that case,
item['name'].presence || item['content']returnsnil, whichcauses an error during validation. Using
item['name'] || item['content']instead will still use
item['content']whenitem['name']is not set at all,but return an empty string in Pleroma's case, which will nicely reject the
blank option without raising an error.