Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expensive counters from federation page in admin UI #11139

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jun 21, 2019

No description provided.

@Gargron Gargron added moderation Administration and moderation tooling performance Runtime performance labels Jun 21, 2019
@Gargron Gargron force-pushed the fix-federation-ui-perf branch from 4e4fd16 to 9422ff6 Compare June 21, 2019 19:34
@Gargron Gargron removed the performance Runtime performance label Jun 21, 2019
@nightpool
Copy link
Member

is this necessary? it's a pretty niche endpoint and the numbers are useful

@Gargron
Copy link
Member Author

Gargron commented Jun 21, 2019

I think it's annoying how long the domain blocks page loads. I added the numbers because I initially thought the same as you, but domain blocks are visited when you have a goal of either confirming something is blocked or adding a block and you don't want to take longer than necessary on either of those tasks.

@Gargron
Copy link
Member Author

Gargron commented Jun 21, 2019

Mind that for the "list of all known servers", the count has no effect on performance because the original query does a seqscan on the whole table anyway. So in that view, I keep the account counter, but replacing the "avatar stack" with it. The avatar stack was pretty but not worth it for the extra time it took. Yeah, it was cached, but you don't usually return to that page often so it's the first load that matters.

@nightpool
Copy link
Member

oh I missed that the account counter was still there.

@Gargron Gargron merged commit 1b052c7 into master Jun 21, 2019
@Gargron Gargron deleted the fix-federation-ui-perf branch June 21, 2019 22:39
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
rtucker referenced this pull request in vulpineclub/mastodon Jan 7, 2021
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moderation Administration and moderation tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants