Fix already-known remote private toots not being searchable by URL #12336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever an URL search fails, and an account is provided, try getting a private status matching that URL from database.
ykzts
approved these changes
Nov 9, 2019
Gargron
requested changes
Nov 10, 2019
app/services/resolve_url_service.rb
Outdated
| elsif fetched_resource.nil? && @on_behalf_of.present? | ||
| # It may happen that the resource is a private toot, and thus not fetchable, | ||
| # but we can return the toot if we already know about it. | ||
| status = Status.find_by(id: @url) || Status.find_by(url: @url) |
There was a problem hiding this comment.
Did you mean uri instead of id?
Gargron
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever an URL search fails, and an account is provided, try getting a
private status matching that URL from database.
Drawbacks of this approach:
urlattribute may not be unique, as that cannot be enforced without fetching it. Thus, a misbehaving server may cause an URL to resolve in non-deterministic ways. I can't see any reason for someone to do that, though.url.