Add relationship-based options to status dropdowns #12377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #10514 i think? |
ykzts
requested changes
Nov 14, 2019
app/javascript/mastodon/features/status/components/action_bar.js
Outdated
Show resolved
Hide resolved
app/javascript/mastodon/features/status/components/action_bar.js
Outdated
Show resolved
Hide resolved
Move bookmark action in inline statuses from action bar to dropdown
Gargron
force-pushed
the
feature-dynamic-mute-options-in-dropdown
branch
from
8469564 to
7e935b2
Compare
ykzts
approved these changes
Nov 19, 2019
Gargron
added a commit
that referenced
this pull request
Nov 19, 2019
Gargron
added a commit
that referenced
this pull request
Nov 19, 2019
|
Well, not everyone wants the lovely bookmark icon to be removed... |
|
Note that on non-mobile, this may cause the menu to change while displayed, because of the relationship info being updated after the menu gets shown. On mobile, the behavior is different, with the updated relationship not updating the menu. EDIT: Also, keyboard navigation gets reset if the current selected item gets updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always showing mute/block, fetch up-to-date relationship when the status dropdown is opened, to be able to also show unmute/unblock as well as block/unblock the domain.
Move bookmark action in inline statuses from action bar to dropdown