Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counter sizing #12446

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix counter sizing #12446

merged 1 commit into from
Nov 29, 2019

Conversation

brawaru
Copy link
Contributor

@brawaru brawaru commented Nov 22, 2019

Counter size is currently set to strict 33.3% width, but with it counters may break in other languages than English. For example it is already broken on Gargron's profile on mastodon.social using Russian locale:

Example screenshot of broken counter

This commit changes "width" to "min-width", so counters still displayed correctly, but if they need more width to fit text, they are now allowed to take as many width as they need:

Example screenshot of fixed counter

Counter size is currently set to strict 33.3% width, but with it
counter may break in other languages than English. For example it is
already broken on Gargron's profile on mastodon.social using Russian
locale.

This commit changes "width" to "min-width", so counters still displayed
correctly, but if they need more width to fit text, they are now allowed
to take as many width as they need.
@Gargron Gargron merged commit b532ead into mastodon:master Nov 29, 2019
@brawaru brawaru deleted the fix/counter-sizing branch April 2, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants