Split relationships page strings #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this moment relationships managing page was using strings from other context - from counters, but in order for translators to be able to translate it relatively to the page, it must use separate strings. I've split the strings for "Following" and "Followers" and put them to "relationships" keyset in localization file. This should solve this issue. Fixes #10863
Gargron
reviewed
Nov 30, 2019
| @@ -8,8 +8,8 @@ | |||
| .filter-subset | |||
| %strong= t 'relationships.relationship' | |||
| %ul | |||
| %li= filter_link_to t('accounts.following', count: current_account.following_count), relationship: nil | |||
| %li= filter_link_to t('accounts.followers', count: current_account.followers_count), relationship: 'followed_by' | |||
There was a problem hiding this comment.
Maybe we could just access accounts.followers.other directly? Just thinking about reducing translation overhead
There was a problem hiding this comment.
Unfortunately no, they are similar in English, but may differ in other languages (they do in Russian actually). So I think it's the best solution for us to have separate strings based on context, that's what issue #10863 was exactly in the first place.
Also, accounts.following seems to be incorrect, because in original context it is used as plural, but in translation file it is a string:
Want me to fix that in this or another PR?
Gargron
approved these changes
Dec 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this moment relationships managing page was using strings from other context — from counters. But in order for translators to be able to translate it relatively to the page (as a tab there), it must use separate strings.
I've split the strings for "Following" and "Followers" and put them to "relationships" keyset in localization file. This should solve this issue.
Fixes #10863