Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Show thread" button to public profiles #13000

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Add "Show thread" button to public profiles #13000

merged 1 commit into from
Jan 29, 2020

Conversation

brawaru
Copy link
Contributor

@brawaru brawaru commented Jan 28, 2020

This adds "Show thread" button to the status view which is used in profiles. The logic to display the button is mimicking logic in web app available at app/javascript/mastodon/components/status.js#L439:

https://github.com/tootsuite/mastodon/blob/60e160a02d47c4b3825dc1fd249ee5b4847022c5/app/javascript/mastodon/components/status.js#L439-L443

The little change in components CSS required to remove enforced underline for all links on public pages on our button.

Screenshot demonstrating the button with red arrow pointing at it with text on white backgroud “Slick button” and WordArd “Wow” at the right bottom

This adds "Show thread" button to the status view which is used in
profiles. The logic to display the button is mimicking logic in
web app available at app/javascript/mastodon/components/status.js#L439.

* The little change in components CSS required to remove enforced
  underline for all links on public pages on our button.
@brawaru
Copy link
Contributor Author

brawaru commented Jan 28, 2020

Let's also take minute to appreciate the number of this Pull Request — #13000.

Click to appreciate Oh, this… is a beautiful number... Wonder, what's behind its meaning...
Click for meaning Probably… great and beautiful future… for Mastodon… for us all…
Anyways… GUD CATCH THERE 🅱️UD 😂 😂 😂 👌 👌
. . . sry for that, pls no ban

@Gargron
Copy link
Member

Gargron commented Jan 29, 2020

You really deep fried that screenshot huh

@Gargron Gargron merged commit 50cd73e into mastodon:master Jan 29, 2020
@brawaru brawaru deleted the feat/show-thread-status-view branch April 2, 2020 22:18
rtucker pushed a commit to vulpineclub/mastodon that referenced this pull request Jan 7, 2021
This adds "Show thread" button to the status view which is used in
profiles. The logic to display the button is mimicking logic in
web app available at app/javascript/mastodon/components/status.js#L439.

* The little change in components CSS required to remove enforced
  underline for all links on public pages on our button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants