Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate notification and delivery of mentions #14378

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix duplicate notification and delivery of mentions #14378

merged 1 commit into from
Jul 23, 2020

Conversation

noellabo
Copy link
Contributor

Fix duplicate notification and delivery when multiple mentions to the same account are specified in status text.

ClearlyClaire
ClearlyClaire approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I am not super comfortable with this change but… I think it's correct (oddly enough, though, I can't manage to trigger duplicate notifications).

@Gargron Gargron merged commit 939a473 into mastodon:master Jul 23, 2020
@shleeable
Copy link
Contributor

shleeable commented Jul 23, 2020 •
edited
Loading

I experienced double notifications a few times since upgrading to RC.. if this fixes it, we will see.

shouo1987 pushed a commit to CrossGate-Pawoo/mastodon that referenced this pull request Dec 7, 2022
@noellabo
Fix duplicate notification and delivery of mentions (mastodon#14378)
d418aca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noellabo @shleeable @ClearlyClaire @Gargron