Show announcements in reverse chronological order #15065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Oct 30, 2020
dariusk
added a commit
to friendcamp/mastodon
that referenced
this pull request
Oct 30, 2020
dariusk
added a commit
to friendcamp/mastodon
that referenced
this pull request
Oct 30, 2020
This fixes a bug in mastodon#15065 where the "read" indicator was not getting correctly set. The ID of a dismissed announcement is now correct.
umonaca
pushed a commit
to umonaca/mastodon
that referenced
this pull request
Nov 8, 2020
Gargron
pushed a commit
that referenced
this pull request
Nov 19, 2020
This fixes a bug in #15065 where the "read" indicator was not getting correctly set. The ID of a dismissed announcement is now correct.
ponapalt
added a commit
to ponapalt/mastodon
that referenced
this pull request
Nov 19, 2020
…stodon#15065)"" This reverts commit 80dc240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my server we often have many server-wide events that we announce using the (great) announcements tool. We often have four or five announcements for upcoming events at a time. As it currently stands, the announcements are rendered in the home timeline announcement widget with the oldest announcement being the first one shown, and then you page through until you get to the newest announcement at the end of the list. This means that when a new announcement is made, the user sees the dot on the megaphone icon, clicks on it, then has to page through a bunch of things to get to the new thing.
This PR simply reverses the rendering order so that the newest item is first, and as you page through they get older and older until you hit the oldest at the end of the list. My users requested this change and so far it's a hit with everyone.