Improve Emoji import (fix #15429) #15430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip macOS '._' shadow files in tar archive to speed up import
Gargron
requested changes
Dec 26, 2020
lib/mastodon/emoji_cli.rb
Outdated
| @@ -41,9 +41,14 @@ def import(path) | |||
|
|
|||
| Gem::Package::TarReader.new(Zlib::GzipReader.open(path)) do |tar| | |||
| tar.each do |entry| | |||
| # File exists && Extension is PNG && not a macOS shadow file (begin with ._) | |||
There was a problem hiding this comment.
Comment seems to repeat what's on the line below. The macOS part is relevant but it's not above the line where it's actually checked.
suggestions from Gargron to improve comment Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Remove extraneous comment (macOS-specific comment now with correct line)
Gargron
approved these changes
Dec 30, 2020
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jan 28, 2022
* Improve Emoji import Skip macOS '._' shadow files in tar archive to speed up import * Fix codeclimate format issue with whitespace * Update lib/mastodon/emoji_cli.rb suggestions from Gargron to improve comment Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> * Update emoji_cli.rb Remove extraneous comment (macOS-specific comment now with correct line) Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip macOS '._' shadow files in tar archive to speed up emoji importing. Basic testing showed it to work fine in distinguishing & ignoring shadow files.