tootctl emoji import: case insensitive duplicate check #15738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few hundreds of emojis to one of my instances using
tootctl emoji import
andtar.gz
files.Some of them had duplicates with different case, like this:
They are displayed correctly in the admin and don't cause any issue during import.
However they don't display correctly:
So I ended up removing the duplicates and reuploading the ones that had the same shortcode with a different case but a different image.
As explained by someone on discord (not sure if they want their name to be quoted)
To a least fix the batch import, I have come up with the fix attached to this PR which check of existing emojis regardless of the case.
That fixed the issue for me, for example if I have the
LoL
emoji, importing a tarball containinglol.png
worked, but with the PR it would skip it.