Change trending hashtags to be affected be reblogs #16164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-remove-account-tag-stats
branch
from
82c272c to
a854e3f
Compare
If a status with a hashtag becomes very popular, it stands to reason that the hashtag should have a chance at trending Fix no stats being recorded for hashtags that are not allowed to trend, and stop ignoring bots Remove references to hashtags in profile directory from the code and the admin UI
Gargron
force-pushed
the
fix-remove-account-tag-stats
branch
from
a854e3f to
be556ea
Compare
ykzts
approved these changes
May 7, 2021
noellabo
added a commit
to fedibird/mastodon
that referenced
this pull request
May 8, 2021
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
If a status with a hashtag becomes very popular, it stands to reason that the hashtag should have a chance at trending Fix no stats being recorded for hashtags that are not allowed to trend, and stop ignoring bots Remove references to hashtags in profile directory from the code and the admin UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a status with a hashtag becomes very popular, it stands to reason that the hashtag should have a chance at trending. It makes sense to me that a reblog of a status would count towards the hashtags in that status.
Fix no stats being recorded for hashtags that are not allowed to trend, and stop ignoring bots. Hashtags that are not allowed to trend can still be allowed to show up in searches and elsewhere, where their usage history is shown.
Remove references to hashtags in profile directory from the code and the admin UI. Hashtags in profile directory have been unusable for a few releases now and will most likely not come back in the same form, so it is weird to have references to them in the admin UI.