Log delays in delivery of toots #5225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Japan national day of load testing, aka televising of "Castle in the Sky" on which many internet users post "balse" to SNSs, I noticed Mastodon doesn't have metrics that indicate how it is communicating to the fedeverse. This change is to add logs like below that will show how quickly Mastodon is delivering toots to remote instances as a good measure of how quickly Mastodon is working on queued tasks. source=Pubsubhubbub::DeliveryWorker destination="https://example.com/api/subscriptions/12345" measure#delivery.delay=65sec count#delivered=1 source=ActivityPub::DeliveryWorker destination="https://example.com/inbox" measure#delivery.delay=66sec count#delivered=1
Many specs doesn't set published time.
|
Have you tried hooking up Mastodon to statsd? When configured, Mastodon sends render times, query times, cache hits, and sidekiq processing times to statsd, which can output them into a time series database. Perhaps you could make this be a statsd invocation too, instead of a log entry? |
|
Ok, I'll see how it runs on Heroku. |
|
I'm withdrawing this pull request. Hooking up statsd+Datadog and viewing some code, I found that some of Sidekiq queue are already reporting latency. As for Mastodon, statsd+Datadog
this pull request+Librato
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Japan national day of load testing, aka televising of "Castle in the Sky" on which many internet users post "balse" to SNSs, I noticed Mastodon doesn't have metrics that indicate how it is communicating to the fedeverse.
This change is to add logs like below that will show how quickly Mastodon is delivering toots to remote instances as a good measure of how quickly Mastodon is working on queued tasks.
The additional metrics can be visualized with, e.g., Librato like below.