Improve OEmbed and OpenGraph handling #8669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very likely a regression. Do YouTube videos still embed? Vimeo? You basically begin to rely on them having the "twitter:player" tag |
|
@Gargron both seem to still work, but yeah, looking at the code, it might make sense to add a few checks before preferring OpenGraph to OEmbed… |
ClearlyClaire
force-pushed
the
fixes/oembed-relative-urls
branch
from
8458e45
to
8b1a884
Compare
|
Dropped the OpenGraph preference thing. |
Gargron
approved these changes
Sep 10, 2018
kyori19
pushed a commit
to kyori19/mastodon
that referenced
this pull request
Sep 20, 2018
koppepan1204
pushed a commit
to koppepan1204/mastodon
that referenced
this pull request
Oct 10, 2018
koppepan1204
pushed a commit
to koppepan1204/mastodon
that referenced
this pull request
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8062 by handling relative URLs in OpenGraph and OEmbed.
It also prefers OpenGraph to OEmbed as the former relies on less HTTP queries, but I don't know if there are reasons to prefer OEmbed anyway when both are available.