Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ruby ==2.5.2== 2.5.3 #9003

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Use Ruby ==2.5.2== 2.5.3 #9003

merged 3 commits into from
Oct 18, 2018

Conversation

zunda
Copy link
Contributor

@zunda zunda commented Oct 18, 2018

https://www.ruby-lang.org/en/news/2018/10/17/ruby-2-5-2-released/

Ruby 2.5.2 fixes

  • CVE-2018-16396: Tainted flags are not propagated in Array#pack and String#unpack with some directives
  • CVE-2018-16395: OpenSSL::X509::Name equality check does not work correctly

@zunda
Use Ruby 2.5.2
570b93c
@zunda
Specify 2.5.2p104 as RUBY VERSION
bde2431 
Heorku refers to RUBY VERSION in Gemfile.lock
@zunda
Copy link
Contributor Author

zunda commented Oct 18, 2018

We may have to wait for CircleCI to be ready to run ruby-2.5.2 for reliable test results.

@shleeable
Copy link
Contributor

2.5.3 is out (buildscript fixes)

@zunda zunda changed the title Use Ruby 2.5.2 Use Ruby ==2.5.2== 2.5.3 Oct 18, 2018
@Gargron Gargron merged commit e576287 into mastodon:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zunda @shleeable @Gargron