Implement adding a user to a list from their profile #9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to fix css? |
|
You need to:
|
Gargron
changed the title
|
・・・Error？Why？ |
|
Seems unrelated to you, the 2.5 ruby tests passed. |
|
Is there any chance you can take a screenshot and put it in the description? |
|
I skipped the word " in the description" and was delayed in fixing it. |
|
Did you have any problems with this patch? |
Gargron
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6058
Add it only when you are following the "Add or Remove from Lists" button on the menu of the account
and add it to the list along with the option of creating a new list on the new ListAdder Modal screen created referring to ListEditor.
ListAdder's name is miserable, but I had no sense of naming. Also, since there is no experience of CSS or HTML <div> structure, I am worried about whether I could do it properly.
I used Javascript and css for the first time as I really wanted this function.
I tried as much as I could but please let me know if there is any problem.