Include preview cards in status entity in REST API #9120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
added
api
ykzts
approved these changes
Oct 27, 2018
Gargron
force-pushed
the
feature-cards-in-stream
branch
from
ac77ed7
to
57d1ccc
Compare
TheInventrix
added a commit
to TheInventrix/mastodon
that referenced
this pull request
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1495
Fix #7208
A link can sometimes be fetched before the status is distributed. In other cases, first distribution includes no card. However, with the preview card resetting the cache of its status, the card will appear on subsequent loads. This might be acceptable.
When used from the in-stream status component, the card uses "compact" styling, which omits the description of the link and enforces a single-line rule for titles, and shrinks the thumbnail to 60px width, unless the preview is interactive. When the preview is interactive (e.g. YouTube), the thumbnail with action buttons is shown at 16:9, with no description section and no border.