Add configuration option to filter replies in lists #9205

ClearlyClaire · 2018-11-04T14:57:30Z

There are three possible settings:

Don't show replies (same behavior as Mastodon 2.6)
Show all replies to followed users (same behavior as Mastodon < 2.6)
Show only replies to users in the list (default)

Changing is done by ~~clicking on the link, which cycles between the settings (yeah, that's not great UI)~~ a set of radio buttons.

~~Note that only “show all replies” shows mentions to yourself. That could probably be changed.~~
All settings show replies to yourself.

ClearlyClaire · 2018-11-04T21:51:19Z

I kept messing up the condition 😩
But I'm confident it is correct now, and I added specs covering most cases.

UI-wise, it would probably be better to have a dropdown, but the only dropdown of this kind is the privacy dropdown, and it's not easily reusable.

ClearlyClaire · 2018-11-06T14:33:44Z

Would anyone actually make use of the “show only replies to users in the list” option? This seems to cover most—if not all—needs, and it would make the code and UI simpler if it were the only option.

CC @cbayerlein @saper as you were the main people discussing this in #5916

cbayerlein · 2018-11-08T13:02:13Z

I think it'sfine as it is now, although it's always good to provide options to the users.

trwnh · 2018-11-08T15:58:19Z

I would use those 3 and also a "show all replies" option, ideally. It depends on the list. I'd conceptualize the setting as the following:

Show replies to...
- Nobody
- Others in this list
- Others you follow
- Everybody

edit for clarification: this is in reply to @ThibG:

Would anyone actually make use of the “show only replies to users in the list” option? This seems to cover most—if not all—needs, and it would make the code and UI simpler if it were the only option.

nightpool · 2018-11-08T17:12:58Z

@trwnh can you be more specific?

…

On Thu, Nov 8, 2018, 10:58 AM trwnh ***@***.***> wrote: I would use those 3 and also a "show all replies" option, ideally. It depends on the list. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9205 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAORVyRvA9ffxOR9LfLcyTeqCQbuFJ4iks5utFSigaJpZM4YNVo7> .

nightpool · 2018-11-08T17:13:34Z

regardless, I absolutely agree with gargron that we shouldn't be doing this filtering server side

…

On Thu, Nov 8, 2018, 10:58 AM trwnh ***@***.***> wrote: I would use those 3 and also a "show all replies" option, ideally. It depends on the list. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9205 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAORVyRvA9ffxOR9LfLcyTeqCQbuFJ4iks5utFSigaJpZM4YNVo7> .

ClearlyClaire · 2018-11-08T17:29:04Z

regardless, I absolutely agree with gargron that we shouldn't be doing this filtering server side

Why? (Also, uh, it would be nice if said opinion of gargron was actually in the issue?)

elegaanz · 2018-11-08T17:30:41Z

I would personnaly like to use both the "Show only replies to users in the list" and "Show all replies to followed users" options.

ClearlyClaire · 2018-11-12T15:57:15Z

Got some feedback from @nightpool on discord (I'll paraphrase them, and quotes will be from them):

Doing this server-side would be confusing, “because users intuitively expect most filtering changes to be retroactive”
They do not see value in having multiple choices and believe the correct behavior would be to only show replies to members of the list.

I personally think there is value in having the choices I described, and I think there is value in doing the filtering server-side (having the same behavior across clients without needing special support, avoiding useless data traffic), but I also understand the point about the filter not applying retroactively being confusing.

ClearlyClaire · 2018-11-24T21:33:55Z

About the filtering not being retroactive, the same can be said about list creation itself: only toots received after the list has been created will appear there. If you think changing filtering after creation is too confusing, it could be possible to choose the type of filtering upfront and not providing any UI to change it (although I would find it problematic).

Of course, we could also not filter at all in the backend and do it in the front-end instead, but this may lead to inconsistent behavior across clients if they are not updated to deal with a new API, and it will also cause increased traffic, as unneeded toots may be streamed for every list.

I'm open to implementing client-side filtering, although I prefer server-side filtering for the above reasons (and also because I've already done the work, tbh).

benjaminbillet · 2018-11-30T18:02:36Z

I don't really understand why this is not merged yet. The new list system makes no sense, what is the point of using lists if you also have to scroll your home to see if you don't miss anything? :s

ClearlyClaire · 2018-11-30T21:30:25Z

This has been merged into glitch-soc, together with a change to the UI that I just ported.
This looks like this:

trwnh · 2018-12-02T04:27:51Z

@ThibG Looks good! I'd just ask for one more option for "everyone", which shows all replies that you have permission to see.

ClearlyClaire · 2018-12-02T11:56:21Z

@trwnh I will consider this, but as this would show more thing than the Home timeline we currently have, this seems a bit counter-intuitive. Also, this is slightly more involved as toots delivered to lists are pre-filtered with the same criteria as for the Home timeline.

trwnh · 2018-12-03T00:35:09Z

@ThibG I guess that's true. The reason I'm interested in it is because I miss the functionality from Tweetdeck circa 2011 where you could show all replies in both home timelines and in lists. That might be a separate request, though... I should probably look into a separate issue for that.

kit-ty-kate · 2018-12-09T12:30:29Z

@trwnh i think this can be added later, I would also like to have this option for both the home timeline and lists

ClearlyClaire · 2019-04-26T20:02:50Z

I've personally been using a few lists, one of which is set to “any followed user” while the others are using the default “members of the list” option. It is extremely useful to me, and I've seen multiple people ask for something like this.

Can this PR be reconsidered? Would changing it to do the filtering client-side help?

stale · 2019-10-26T03:35:33Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

wryk · 2020-01-06T09:22:06Z

I think this PR is still relevant. Without replies in lists users need to scroll the home timeline (miss the point of using lists) or peek at profile pages (not viable with large lists)

ClearlyClaire · 2020-01-06T09:47:57Z

Reopening, but I doubt Gargron changed his mind on this :/

stale · 2020-08-03T11:51:49Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SuperSandro2000 · 2020-08-11T11:59:03Z

Bump

Gargron

LGTM but wondering about API naming

Gargron · 2020-09-01T01:12:53Z

db/migrate/20181127165847_add_show_replies_to_lists.rb

+    safety_assured do
+      add_column_with_default(
+        :lists,
+        :replies_policy,


This is the first enum in our code we call _policy, I don't want to bikeshed too much but is this a fully appropriate name?

This has been in glitch-soc for almost two years, so I'd need to check if any client uses that API, but otherwise I'm fine with changing the name if you have a better suggestion.

Gargron

Actually upon seeing the screenshot down thread I have a few more concerns

app/javascript/mastodon/features/list_timeline/index.js

Gargron · 2020-09-01T01:16:11Z

app/javascript/mastodon/features/list_timeline/index.js

+                    <legend><FormattedMessage id='lists.replies_policy.title' defaultMessage='Show replies to:' /></legend>
+                    { ['no_replies', 'list_replies', 'all_replies'].map(policy => (
+                      <div className='setting-radio'>
+                        <input className='setting-radio__input' id={['setting', 'radio', id, policy].join('-')} type='radio' value={policy} checked={replies_policy === policy} onChange={this.handleRepliesPolicyChange} />


Plain radio buttons look rather unsightly in there, can we use the toggles we use in other column settings?

Someone pointed out that we already have radio buttons somewhere else in the interface (directory settings), I'll have a look to reuse that styling.

…tings

ClearlyClaire · 2020-09-01T08:24:27Z

Updated the radio button design to look like the directory column design:

…y explorer

* Add database support for list show-reply preferences * Add backend support to read and update list-specific show_replies settings * Add basic UI to set list replies setting * Add specs for list replies policy * Switch "cycling" reply policy link to a set of radio inputs * Capitalize replies_policy strings * Change radio button design to be consistent with that of the directory explorer

ClearlyClaire force-pushed the features/lists-replies branch 2 times, most recently from 389ba55 to cd98334 Compare November 4, 2018 21:08

ClearlyClaire force-pushed the features/lists-replies branch from 6f869fb to fb7fdf1 Compare November 12, 2018 14:46

ClearlyClaire force-pushed the features/lists-replies branch from fb7fdf1 to 1b85c7f Compare November 21, 2018 15:44

ClearlyClaire mentioned this pull request Nov 21, 2018

Include replies to list owner and replies to list members in list statuses #9324

Merged

ClearlyClaire force-pushed the features/lists-replies branch from 1b85c7f to fe02e79 Compare November 21, 2018 16:46

ClearlyClaire force-pushed the features/lists-replies branch from fe02e79 to 4d35b68 Compare November 27, 2018 16:00

ClearlyClaire force-pushed the features/lists-replies branch 2 times, most recently from bb1f594 to 9185b94 Compare November 30, 2018 21:28

ClearlyClaire force-pushed the features/lists-replies branch from 9185b94 to e63af3b Compare December 9, 2018 13:28

ClearlyClaire force-pushed the features/lists-replies branch from e63af3b to 8a7c453 Compare January 4, 2019 12:18

stale bot added the status/wontfix This will not be worked on label Oct 26, 2019

kit-ty-kate mentioned this pull request Nov 7, 2019

Backfill statuses from remote accounts when first subscribed #34

Open

ClearlyClaire reopened this Jan 6, 2020

stale bot removed the status/wontfix This will not be worked on label Jan 6, 2020

ykzts approved these changes Jan 10, 2020

View reviewed changes

stale bot added the status/wontfix This will not be worked on label Aug 3, 2020

stale bot closed this Aug 10, 2020

ClearlyClaire reopened this Aug 31, 2020

stale bot removed the status/wontfix This will not be worked on label Aug 31, 2020

Gargron approved these changes Sep 1, 2020

View reviewed changes

Gargron requested changes Sep 1, 2020

View reviewed changes

ClearlyClaire force-pushed the features/lists-replies branch from 8a7c453 to b428c0e Compare September 1, 2020 08:00

ClearlyClaire added 6 commits September 1, 2020 10:22

Add database support for list show-reply preferences

52e4e84

Add backend support to read and update list-specific show_replies set…

69b1962

…tings

Add basic UI to set list replies setting

b931ea2

Add specs for list replies policy

2dc0d2e

Switch "cycling" reply policy link to a set of radio inputs

05265f3

Capitalize replies_policy strings

954db18

ClearlyClaire force-pushed the features/lists-replies branch from b428c0e to aa19de1 Compare September 1, 2020 08:22

Change radio button design to be consistent with that of the director…

79d70fb

…y explorer

ClearlyClaire force-pushed the features/lists-replies branch from aa19de1 to 79d70fb Compare September 1, 2020 08:39

Gargron approved these changes Sep 1, 2020

View reviewed changes

Gargron merged commit 7930542 into mastodon:master Sep 1, 2020

trwnh mentioned this pull request Dec 6, 2020

replies_policy naming precludes future option to show "all replies" for real #15278

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configuration option to filter replies in lists #9205

Add configuration option to filter replies in lists #9205

ClearlyClaire commented Nov 4, 2018 •

edited

Loading

ClearlyClaire commented Nov 4, 2018

ClearlyClaire commented Nov 6, 2018 •

edited

Loading

cbayerlein commented Nov 8, 2018

trwnh commented Nov 8, 2018 •

edited

Loading

nightpool commented Nov 8, 2018 via email

nightpool commented Nov 8, 2018 via email

ClearlyClaire commented Nov 8, 2018

elegaanz commented Nov 8, 2018

ClearlyClaire commented Nov 12, 2018

ClearlyClaire commented Nov 24, 2018

benjaminbillet commented Nov 30, 2018

ClearlyClaire commented Nov 30, 2018

trwnh commented Dec 2, 2018

ClearlyClaire commented Dec 2, 2018

trwnh commented Dec 3, 2018

kit-ty-kate commented Dec 9, 2018

ClearlyClaire commented Apr 26, 2019

stale bot commented Oct 26, 2019

wryk commented Jan 6, 2020

ClearlyClaire commented Jan 6, 2020

stale bot commented Aug 3, 2020

SuperSandro2000 commented Aug 11, 2020

Gargron left a comment

Gargron Sep 1, 2020

ClearlyClaire Sep 1, 2020

Gargron left a comment

Gargron Sep 1, 2020

ClearlyClaire Sep 1, 2020

ClearlyClaire commented Sep 1, 2020 •

edited

Loading

Add configuration option to filter replies in lists #9205

Add configuration option to filter replies in lists #9205

Conversation

ClearlyClaire commented Nov 4, 2018 • edited Loading

ClearlyClaire commented Nov 4, 2018

ClearlyClaire commented Nov 6, 2018 • edited Loading

cbayerlein commented Nov 8, 2018

trwnh commented Nov 8, 2018 • edited Loading

nightpool commented Nov 8, 2018 via email

nightpool commented Nov 8, 2018 via email

ClearlyClaire commented Nov 8, 2018

elegaanz commented Nov 8, 2018

ClearlyClaire commented Nov 12, 2018

ClearlyClaire commented Nov 24, 2018

benjaminbillet commented Nov 30, 2018

ClearlyClaire commented Nov 30, 2018

trwnh commented Dec 2, 2018

ClearlyClaire commented Dec 2, 2018

trwnh commented Dec 3, 2018

kit-ty-kate commented Dec 9, 2018

ClearlyClaire commented Apr 26, 2019

stale bot commented Oct 26, 2019

wryk commented Jan 6, 2020

ClearlyClaire commented Jan 6, 2020

stale bot commented Aug 3, 2020

SuperSandro2000 commented Aug 11, 2020

Gargron left a comment

Choose a reason for hiding this comment

Gargron Sep 1, 2020

Choose a reason for hiding this comment

ClearlyClaire Sep 1, 2020

Choose a reason for hiding this comment

Gargron left a comment

Choose a reason for hiding this comment

Gargron Sep 1, 2020

Choose a reason for hiding this comment

ClearlyClaire Sep 1, 2020

Choose a reason for hiding this comment

ClearlyClaire commented Sep 1, 2020 • edited Loading

ClearlyClaire commented Nov 4, 2018 •

edited

Loading

ClearlyClaire commented Nov 6, 2018 •

edited

Loading

trwnh commented Nov 8, 2018 •

edited

Loading

ClearlyClaire commented Sep 1, 2020 •

edited

Loading