Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for avatar image that's too large. #9204 #9518

Merged
merged 7 commits into from
Dec 14, 2018

Conversation

sumdog
Copy link
Contributor

@sumdog sumdog commented Dec 13, 2018

This should fix #9204.

Notes:

  • I'm not sure if the error message is in the right locale file
  • I couldn't find a way to get the error messages directly off the controller in the test, so I test against the HTML body.

app/services/update_account_service.rb Outdated Show resolved Hide resolved
@Gargron Gargron merged commit 769c2d2 into mastodon:master Dec 14, 2018
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…don#9518)

* Error message for avatar image that's too large. mastodon#9204

* Code climate/formatting

* Removed avatar error message

* Moved valid image dimentions check to update service

* removed unnescessary begin block

* code climate formatting

* code climate indent fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar upload doesn't display error for large images
2 participants