Add moderation warnings #9519

Gargron · 2018-12-14T00:40:53Z

Moderation warnings are meant to formalize the process of warning users about their misconduct prior to harsher measures, so that other staff can track that process. At the same time, the warning system is meant to solve the issue of absolute intransparency about moderation actions concerning your account, i.e. if you are banned, you won't know when and why you were banned.

However, sometimes moderation actions need to be covert, and as such, you can opt to generate no warnings/e-mails when perfming said actions.

In terms of moderation UI, whereas previously, "disable" and "silence" were one-click actions, now they are unified into a form that allows you to enter warning text (or choose from custom presets to save time). That form likewise oversees the "suspend" action, which previously was on a separate page that required you to enter the username of the account for confirmation (that is no longer so).

That new form is not only unified between various actions, but also between actions that are part of a report, and actions taken directly from the account page. Of course, warnings can only be sent to local users.

Action UI:

E-mail the user receives:

Warning presets UI:

Here are the e-mail contents for various action types:

Action	Subject	Message (above optional custom text)
none	Warning for %{acct}
disable	Your account %{acct} has been frozen	While your account is frozen, your account data remains intact, but you cannot perform any actions until it is unlocked.
silence	Your account %{acct} has been limited	While your account is limited, only people who are already following you will see your toots on this server, and you may be excluded from various public listings. However, others may still manually follow you.
suspend	Your account %{acct} has been suspended	Your account has been suspended, and all of your toots and your uploaded media files have been irreversibly removed from this server, and servers where you had followers.

Below this explanation, you can enter custom text, or choose one of the preset options. You can add presets.

The e-mail also contains a link to "review server policies" at /about/more

Packbat · 2018-12-21T23:58:51Z

I think it would make sense to include account and instance in the subject line and message. Tentative suggestion:

Action	Subject	Message (above optional custom text)
none	Warning for [account]@[instance]
disable	Your account [account]@[instace] has been disabled	You have been locked out of your account [account]@[instance]. Your login sessions and app tokens are still intact, but you cannot perform any actions until your account is unlocked.
silence	Your account [account]@[instance] has been quarantined	While your account [account]@[instance] is quarantined, only people who are already following you will see your toots on this server.
suspend	Your account [account]@[instance] has been deleted	Your account [account]@[instance] and all of your toots and media attachments have been removed.

Gargron · 2018-12-22T01:22:37Z

Updated table.

joyeusenoelle · 2018-12-22T01:30:23Z

Suggest additional text after the custom text, along the lines of:

disable: "Please contact <admin email address> to discuss re-enabling your login."
silence: "Please contact <admin email address> to discuss removing the limit on your account."
suspend: "Your account cannot be recovered. If you return to Mastodon, please choose another server here: https://joinmastodon.org ."

Replace individual routes for disabling, silencing, and suspending a user, as well as the report update route, with a unified account action controller that allows you to select an action (none, disable, silence, suspend) as well as whether it should generate an e-mail notification with optional custom text. That notification, with the optional custom text, is saved as a warning. Additionally, there are warning presets you can configure to save time when performing the above.

tribela · 2018-12-22T01:31:33Z

What's mean "none"?
Will send email at just reported? or send at mark as solved?

Gargron · 2018-12-22T01:32:40Z

None means no action against the account, allows you to just send a warning e-mail. Sending a warning with no action when coming from a report will mark that particular report as closed.

tribela · 2018-12-22T01:35:43Z

I suggest to send this kind of emails to the reporters.
When I using Twitter's one, It was very not satisfied which not giving any feedback for reportings.

krainboltgreene · 2018-12-22T09:02:33Z

app/controllers/admin/reports_controller.rb

@@ -13,75 +13,42 @@ def show
      authorize @report, :show?

      @report_note  = @report.notes.new
-      @report_notes = (@report.notes.latest + @report.history).sort_by(&:created_at)
+      @report_notes = (@report.notes.latest + @report.history + @report.target_account.targeted_account_warnings.latest.custom).sort_by(&:created_at)


Might be time to create a view.

In most cases this is only 4-5 items at most in total. That being said, how do I query a view in Rails?

app/mailers/user_mailer.rb

krainboltgreene · 2018-12-22T09:05:43Z

app/models/account_warning.rb

+
+  scope :latest, -> { order(created_at: :desc) }
+  scope :custom, -> { where.not(text: '') }
+end


Validate the enum and create a constant for future reference?

Validate the enum how? I believe the enum can't be set to a value that isn't defined

Oh, right I forgot rails does that!

Cassolotl · 2018-12-22T21:45:45Z

Is "Notify the user per email" the same meaning as "Notify the user by email"? I've not seen it written that way before.

danhunsaker · 2018-12-23T00:32:14Z

I tend to see/use "via" rather than "by", but agree that "per" seems unusual, and may in fact have a different meaning than intended. ("Per" generally means "in accordance with".)

Gargron · 2018-12-23T01:38:13Z

It should be "by", my mistake

ClearlyClaire · 2018-12-23T13:50:19Z

Nothing in the admin accounts UI explains that those records are warnings.

* Add moderation warnings Replace individual routes for disabling, silencing, and suspending a user, as well as the report update route, with a unified account action controller that allows you to select an action (none, disable, silence, suspend) as well as whether it should generate an e-mail notification with optional custom text. That notification, with the optional custom text, is saved as a warning. Additionally, there are warning presets you can configure to save time when performing the above. * Use Account#local_username_and_domain

Gargron added work in progress Not to be merged, currently being worked on moderation Administration and moderation tooling labels Dec 14, 2018

Gargron force-pushed the feature-moderation-warnings branch 12 times, most recently from 4c58062 to 3a8a955 Compare December 21, 2018 22:27

Gargron removed the work in progress Not to be merged, currently being worked on label Dec 21, 2018

Gargron force-pushed the feature-moderation-warnings branch from 3a8a955 to 1857971 Compare December 21, 2018 22:29

Gargron force-pushed the feature-moderation-warnings branch from 1857971 to 032339f Compare December 22, 2018 01:16

Gargron force-pushed the feature-moderation-warnings branch from 032339f to 1b1f184 Compare December 22, 2018 01:31

krainboltgreene reviewed Dec 22, 2018

View reviewed changes

app/mailers/user_mailer.rb Outdated Show resolved Hide resolved

krainboltgreene reviewed Dec 22, 2018

View reviewed changes

krainboltgreene approved these changes Dec 22, 2018

View reviewed changes

Use Account#local_username_and_domain

72f95c2

Gargron merged commit 3c033c4 into master Dec 22, 2018

Gargron deleted the feature-moderation-warnings branch December 22, 2018 19:02

Gargron mentioned this pull request Dec 24, 2018

Limit maximum visibility of local silenced users to unlisted #9583

Merged

mkljczk mentioned this pull request Jan 1, 2019

[WIP] notify users after admin actions #8693

Closed

Gargron mentioned this pull request Feb 2, 2019

WIP: Mark reports targeting the account as resolved when suspending #7247

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add moderation warnings #9519

Add moderation warnings #9519

Gargron commented Dec 14, 2018 •

edited

Loading

Packbat commented Dec 21, 2018

Gargron commented Dec 22, 2018

joyeusenoelle commented Dec 22, 2018 •

edited

Loading

tribela commented Dec 22, 2018

Gargron commented Dec 22, 2018

tribela commented Dec 22, 2018

krainboltgreene Dec 22, 2018

Gargron Dec 22, 2018

krainboltgreene Dec 22, 2018

Gargron Dec 22, 2018

krainboltgreene Dec 24, 2018

Cassolotl commented Dec 22, 2018

danhunsaker commented Dec 23, 2018

Gargron commented Dec 23, 2018

ClearlyClaire commented Dec 23, 2018

Add moderation warnings #9519

Add moderation warnings #9519

Conversation

Gargron commented Dec 14, 2018 • edited Loading

Packbat commented Dec 21, 2018

Gargron commented Dec 22, 2018

joyeusenoelle commented Dec 22, 2018 • edited Loading

tribela commented Dec 22, 2018

Gargron commented Dec 22, 2018

tribela commented Dec 22, 2018

krainboltgreene Dec 22, 2018

Choose a reason for hiding this comment

Gargron Dec 22, 2018

Choose a reason for hiding this comment

krainboltgreene Dec 22, 2018

Choose a reason for hiding this comment

Gargron Dec 22, 2018

Choose a reason for hiding this comment

krainboltgreene Dec 24, 2018

Choose a reason for hiding this comment

Cassolotl commented Dec 22, 2018

danhunsaker commented Dec 23, 2018

Gargron commented Dec 23, 2018

ClearlyClaire commented Dec 23, 2018

Gargron commented Dec 14, 2018 •

edited

Loading

joyeusenoelle commented Dec 22, 2018 •

edited

Loading