Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip mailer job retries when a record no longer exists #9590

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Skip mailer job retries when a record no longer exists #9590

merged 1 commit into from
Dec 21, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Dec 20, 2018

Fix #8666

@Gargron Gargron added the bug Something isn't working label Dec 20, 2018
@ClearlyClaire
Copy link
Contributor

I'm concerned this may be too broad? But on the other hand, I can't see any occurrence where a job would fail with this error then work on a next attempt, hm…

@Gargron
Copy link
Member Author

Gargron commented Dec 20, 2018

@ThibG This is only within the ActiveMailer job, not any other Sidekiq workers.

@Gargron Gargron merged commit 240c122 into master Dec 21, 2018
@Gargron Gargron deleted the fix-mailer-deserialization-retries branch December 21, 2018 05:30
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Skip mailer job retries when a record no longer exists (mastodon#9590)
df61f15 
Fix mastodon#8666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gargron @ClearlyClaire @ykzts