Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make draggingOver state off correctly #9797

Merged
merged 5 commits into from
Jan 14, 2019
Merged

make draggingOver state off correctly #9797

merged 5 commits into from
Jan 14, 2019

Conversation

hinaloe
Copy link
Contributor

@hinaloe hinaloe commented Jan 13, 2019 •
edited
Loading

Sometimes, .upload-area could not close when dragging leave to out of window.

image

How to reproduce

  1. drag and drop any contents (Image, Text, and other) on Mastodon window (to same window).
  2. Try drag and drop any file from any file manager to Mastodon window, and cancel (non drop, or drop in original or other location).

Tested on

Chrome and Firefox (macOS, Linux)

Edge and Safari has the same problem reproducibility, but it does not seem to work well.
-> I found the simple way.

@hinaloe
Copy link
Contributor Author

hinaloe commented Jan 13, 2019

This seems to be related to #687

@hinaloe hinaloe changed the title make draggingOver state off correctly [WIP] make draggingOver state off correctly Jan 14, 2019
@hinaloe hinaloe changed the title [WIP] make draggingOver state off correctly make draggingOver state off correctly Jan 14, 2019
@Gargron Gargron merged commit d6433b3 into mastodon:master Jan 14, 2019
@hinaloe hinaloe deleted the fix-dragleave branch January 14, 2019 08:33
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@hinaloe @hiyuki2578
make draggingOver state off correctly (mastodon#9797)
9eccd50 
* make draggingOver stat off correctly

* ignore safari and Edge

* Revert "ignore safari and Edge"

This reverts commit b9b93ea.

* Revert "make draggingOver stat off correctly"

This reverts commit f5fd6b9.

* clear drag stack when drop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hinaloe @ykzts @Gargron