Allow multiple files upload through web UI, including drag & drop #9856
Conversation
|
I have to ask, does this actually work? AJAX requests are asynchronous so making them from a loop does not guarantee sequential execution, and upload progress is a one-for-all state subtree so multiple concurrent requests for different files would be overwriting it all the time |
|
Thanks for the feedback. I see what you're saying about the interaction between the async ajax and the upload progress. Functionally it works, but you are right. After simulating slow speeds I was actually able to see the progress bar and it's not pretty. From what I understand, the store has only one I don't think multiple types in the store would be very elegant, and certainly not extensible. I'll look into what can be done, but I'm pretty new to react/redux so any advice is appreciated. |
|
@Gargron This update keeps the single upload progress bar, but is calculated on the total of all files being uploaded. |
|
Perhaps it would make sense to mark the file input as allowing multiple files, so that multiple files can be selected from the normal dialog, as well? Then you could put "Fix #5556" in your commit message |
…ate update file limit logic, provide file limit feedback
Gargron
changed the title
|
I added in some user feedback for file limits so wanted to get your opinion on using alerts this way from the action. |
|
Yes, I believe it is appropriate 👍 |
…drop (mastodon#9856)" This reverts commit 750c676.
…stodon#9856) * Allow drag and drop uploads of multiple files to compose * Calculate aggregate upload progress for single action * Allow multiple uploads to compose through traditional input, consolidate update file limit logic, provide file limit feedback
…stodon#9856) * Allow drag and drop uploads of multiple files to compose * Calculate aggregate upload progress for single action * Allow multiple uploads to compose through traditional input, consolidate update file limit logic, provide file limit feedback
Maintains maximum limit of four files uploaded. Possible opportunity to abstract to instance setting.
Fix #5556