Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data race caused by controller-runtime #51

Closed
toshipp opened this issue Jul 13, 2021 · 1 comment
Closed

Data race caused by controller-runtime #51

toshipp opened this issue Jul 13, 2021 · 1 comment
Labels
bug Something isn't working
Projects

Comments

@toshipp
Copy link
Contributor

toshipp commented Jul 13, 2021

A data race is detected.
https://github.com/topolvm/pvc-autoresizer/runs/3045524747

WARNING: DATA RACE
Write at 0x00c00000c368 by goroutine 37:
  internal/race.Write()
      /opt/hostedtoolcache/go/1.16.5/x64/src/internal/race/race.go:41 +0x125
  sync.(*WaitGroup).Wait()
      /opt/hostedtoolcache/go/1.16.5/x64/src/sync/waitgroup.go:128 +0x126
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).waitForRunnableToEnd.func2()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:565 +0x44

Previous read at 0x00c00000c368 by goroutine 128:
  internal/race.Read()
      /opt/hostedtoolcache/go/1.16.5/x64/src/internal/race/race.go:37 +0x206
  sync.(*WaitGroup).Add()
      /opt/hostedtoolcache/go/1.16.5/x64/src/sync/waitgroup.go:71 +0x219
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:693 +0x4e
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).serveMetrics()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:382 +0x31b

Goroutine 37 (running) created at:
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).waitForRunnableToEnd()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:564 +0xcb
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).engageStopProcedure()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:546 +0x376
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).Start.func1()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:447 +0x46
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).Start()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:497 +0x575
  github.com/topolvm/pvc-autoresizer/runners.glob..func2.1()
      /home/runner/work/pvc-autoresizer/pvc-autoresizer/runners/suite_test.go:82 +0x5c

Goroutine 128 (finished) created at:
  sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).Start()
      /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.2/pkg/manager/internal.go:471 +0x61b
  github.com/topolvm/pvc-autoresizer/runners.glob..func2.1()
      /home/runner/work/pvc-autoresizer/pvc-autoresizer/runners/suite_test.go:82 +0x5c

This has been already reported to controller-runtime.
kubernetes-sigs/controller-runtime#1442

@toshipp toshipp added the bug Something isn't working label Jul 13, 2021
@project-bot project-bot bot added this to To do in Development Jul 13, 2021
@llamerada-jp
Copy link
Contributor

may be fixed in controller-runtime v0.11.0.
applied in #92

Development automation moved this from To do to Done Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development
  
Done
Development

No branches or pull requests

2 participants