Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-2655] Fix in_transaction collisions with other gems #112

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

catks
Copy link
Member

@catks catks commented Jan 18, 2024

There is a name collision for the in_transaction attribute/method in granite and after_commit_everywhere

Changing the private attribute on granite to fix the issue.

Review

Pre-merge checklist

  • The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
  • Verify that feature branch is up-to-date with master (if not - rebase it).
  • Double check the quality of commit messages.
  • Squash related commits together.

@catks catks force-pushed the devx-2655-fix-after-commit-everywhere-name-collisions branch from 79afedc to 00a23e6 Compare January 19, 2024 13:12
@catks catks marked this pull request as ready for review January 19, 2024 13:37
@catks catks requested a review from a team as a code owner January 19, 2024 13:37
@catks
Copy link
Member Author

catks commented Jan 19, 2024

@toptal-anvil ping reviewers

@catks catks merged commit df1ed6d into master Jan 19, 2024
5 checks passed
@catks catks deleted the devx-2655-fix-after-commit-everywhere-name-collisions branch January 19, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants