Analyzer: Optimize area_to_pandas method
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `area_to_pandas` function has been optimized to significantly improve its execution speed. - Set lookups: Areas are converted to sets for O(1) membership checks, making the `isin` operations more efficient. - Vectorization: Replaced loop-based calculations with vectorized operations for `total_travel_time` and `total_free_time`, leveraging the power of `numpy` and `pandas` to perform these operations in bulk. - Single DataFrame access: Minimized repeated access to DataFrame columns, reducing the overhead of these operations. - Efficient grouping: Used `unique()` and `nunique()` for faster unique element counting.
This was referenced Sep 2, 2024
|
@toruseo I think this PR is relatively straightforward, it just makes this function faster without modifying it's behavior. |
This was referenced Sep 8, 2024
|
Thanks for merging! This PR was fully tested and validated to have identical output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
area_to_pandasfunction has been optimized to significantly improve its execution speed.isinoperations more efficient.total_travel_timeandtotal_free_time, leveraging the power ofnumpyandpandasto perform these operations in bulk.unique()andnunique()for faster unique element counting.In my testing of a large simulation, this sped up the function from ~75 seconds to ~2.5 seconds (about 30x).