Analyzer: Return average_speed and vehicle_density with area_to_pandas #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `area_to_pandas` function has been optimized to significantly improve its execution speed. - Set lookups: Areas are converted to sets for O(1) membership checks, making the `isin` operations more efficient. - Vectorization: Replaced loop-based calculations with vectorized operations for `total_travel_time` and `total_free_time`, leveraging the power of `numpy` and `pandas` to perform these operations in bulk. - Single DataFrame access: Minimized repeated access to DataFrame columns, reducing the overhead of these operations. - Efficient grouping: Used `unique()` and `nunique()` for faster unique element counting.
This commit adds two new columns to the Analyzer.area_to_pandas method: average_speed and vehicle_density.
EwoutH
force-pushed
the
area2pandas_speed_density
branch
from
f4fcde2 to
f0bcb1a
Compare
This was referenced Sep 2, 2024
|
Thanks for merging! I didn't add test for this PR, should I do that somewhere? |
|
yes, that will be fantastic plz add new test(s) to https://github.com/toruseo/UXsim/blob/main/tests/test_other_functions.py like |
|
Thanks, I will add something like: assert equal_tolerance(df["average_speed"][df["area"] == "areaN"].values[0], 10.0, abs_tol=1.0)
assert equal_tolerance(df["vehicle_density"][df["area"] == "areaN"].values[0], 0.007, abs_tol=0.001)Just have to get in a meeting, will add and calibrate the values afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new columns to the
Analyzer.area_to_pandasmethod: average speed and vehicle density. They are calculated as:This PR builds on #119. Please review/merge that PR first. Only the second commit (f0bcb1a) is new in this PR.