Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@toss/react): FullHeight component change hook #474

Merged
merged 1 commit into from
May 31, 2024

Conversation

fronttigger
Copy link
Contributor

@fronttigger fronttigger commented May 7, 2024

Overview

Replace the useIsomorphicLayoutEffect previously declared in the component with a custom hook implemented in @toss/react.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

vercel bot commented May 7, 2024

@fronttigger is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@fronttigger fronttigger changed the title fix(@toss/react/emotion-utils): FullHeight Component change hook fix(@toss/react): FullHeight Component change hook May 9, 2024
@fronttigger fronttigger changed the title fix(@toss/react): FullHeight Component change hook fix(@toss/react): FullHeight component change hook May 17, 2024
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request!

@raon0211 raon0211 merged commit e95595c into toss:main May 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants