Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make ASSETS_URL optional #96

Open
andreicioromila opened this issue Jan 11, 2022 · 1 comment
Open

Feature Request: Make ASSETS_URL optional #96

andreicioromila opened this issue Jan 11, 2022 · 1 comment

Comments

@andreicioromila
Copy link

ASSETS_URL is currently required in order to serve the frontend application for schema registry. However, it is only used inside the HTML page for the frontend. If omitted, browsers would just load the assets from the same host that the user is on.

I am not sure what use case is covered by setting it, but I think the default should be that assetsRootURL is undefined and the browser tries to load just href="/assets/management-ui-standalone.css?v=${assetsVersion}"

@jon-frankel
Copy link

I found setting ASSETS_URL to . works fine. An empty string will cause it to fall back on localhost:6001 but . will cause it use ./assets/management... which does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants