Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: [de]compression layers ignore configuration #132

Merged
merged 6 commits into from
Sep 18, 2021
Merged

Bug fix: [de]compression layers ignore configuration #132

merged 6 commits into from
Sep 18, 2021

Conversation

Madoshakalaka
Copy link
Contributor

@Madoshakalaka Madoshakalaka commented Aug 29, 2021 •
edited
Loading

  • Decompression layer and compression layer now accepts encoding configuration

  • Added regression test to make sure compression layer registers configuration

whoa, so compression layers and decompression layers just ignored those .set_br/.no_br calls...I fixed it!

@Madoshakalaka
fix bug: [de]compression layers ignores configuration
bb79dde 
* Decompression layer and compression layer now accepts encoding configuration

* Add regression test to make sure compression layer registers configuration
@Madoshakalaka
Copy link
Contributor Author

whoops, forgot to remove those println!'s I added while debugging

davidpdrsn
davidpdrsn reviewed Aug 30, 2021
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I think the changes look good, just a couple of minor nit picks.

You might also wanna merge/rebase master to fix CI.

Should probably also mention this fix in the changelog.

tower-http/src/compression/layer.rs Outdated Show resolved Hide resolved
tower-http/src/compression/mod.rs Outdated Show resolved Hide resolved
tower-http/src/compression_utils.rs Outdated Show resolved Hide resolved
tower-http/src/compression/layer.rs Show resolved Hide resolved
@Madoshakalaka Madoshakalaka changed the title Bug fix: [de]compression layers ignores configuration Bug fix: [de]compression layers ignore configuration Sep 1, 2021
@davidpdrsn davidpdrsn merged commit 8e299eb into tower-rs:master Sep 18, 2021
davidpdrsn added a commit that referenced this pull request Nov 13, 2021
@davidpdrsn
Version 0.1.2
8a1627a 
- New middleware: Add `Cors` for setting [CORS] headers ([#112])
- New middleware: Add `AsyncRequireAuthorization` ([#118])
- `Compression`: Don't recompress HTTP responses ([#140])
- `Compression` and `Decompression`: Pass configuration from layer into middleware ([#132])
- `ServeDir` and `ServeFile`: Improve performance ([#137])
- `Compression`: Remove needless `ResBody::Error: Into<BoxError>` bounds ([#117])
- `ServeDir`: Percent decode path segments ([#129])
- `ServeDir`: Use correct redirection status ([#130])
- `ServeDir`: Return `404 Not Found` on requests to directories if
  `append_index_html_on_directories` is set to `false` ([#122])

[#112]: #112
[#118]: #118
[#140]: #140
[#132]: #132
[#137]: #137
[#117]: #117
[#129]: #129
[#130]: #130
[#122]: #122
@davidpdrsn davidpdrsn mentioned this pull request Nov 13, 2021
Merged
davidpdrsn added a commit that referenced this pull request Nov 13, 2021
@davidpdrsn
Version 0.1.2
c3530e1 
- New middleware: Add `Cors` for setting [CORS] headers ([#112])
- New middleware: Add `AsyncRequireAuthorization` ([#118])
- `Compression`: Don't recompress HTTP responses ([#140])
- `Compression` and `Decompression`: Pass configuration from layer into middleware ([#132])
- `ServeDir` and `ServeFile`: Improve performance ([#137])
- `Compression`: Remove needless `ResBody::Error: Into<BoxError>` bounds ([#117])
- `ServeDir`: Percent decode path segments ([#129])
- `ServeDir`: Use correct redirection status ([#130])
- `ServeDir`: Return `404 Not Found` on requests to directories if
  `append_index_html_on_directories` is set to `false` ([#122])

[#112]: #112
[#118]: #118
[#140]: #140
[#132]: #132
[#137]: #137
[#117]: #117
[#129]: #129
[#130]: #130
[#122]: #122
davidpdrsn added a commit that referenced this pull request Nov 13, 2021
@davidpdrsn
Version 0.1.2
470477a 
- New middleware: Add `Cors` for setting [CORS] headers ([#112])
- New middleware: Add `AsyncRequireAuthorization` ([#118])
- `Compression`: Don't recompress HTTP responses ([#140])
- `Compression` and `Decompression`: Pass configuration from layer into middleware ([#132])
- `ServeDir` and `ServeFile`: Improve performance ([#137])
- `Compression`: Remove needless `ResBody::Error: Into<BoxError>` bounds ([#117])
- `ServeDir`: Percent decode path segments ([#129])
- `ServeDir`: Use correct redirection status ([#130])
- `ServeDir`: Return `404 Not Found` on requests to directories if
  `append_index_html_on_directories` is set to `false` ([#122])

[#112]: #112
[#118]: #118
[#140]: #140
[#132]: #132
[#137]: #137
[#117]: #117
[#129]: #129
[#130]: #130
[#122]: #122
davidpdrsn added a commit that referenced this pull request Nov 13, 2021
@davidpdrsn
Version 0.1.2 (#162)
2c110d2 
- New middleware: Add `Cors` for setting [CORS] headers ([#112])
- New middleware: Add `AsyncRequireAuthorization` ([#118])
- `Compression`: Don't recompress HTTP responses ([#140])
- `Compression` and `Decompression`: Pass configuration from layer into middleware ([#132])
- `ServeDir` and `ServeFile`: Improve performance ([#137])
- `Compression`: Remove needless `ResBody::Error: Into<BoxError>` bounds ([#117])
- `ServeDir`: Percent decode path segments ([#129])
- `ServeDir`: Use correct redirection status ([#130])
- `ServeDir`: Return `404 Not Found` on requests to directories if
  `append_index_html_on_directories` is set to `false` ([#122])

[#112]: #112
[#118]: #118
[#140]: #140
[#132]: #132
[#137]: #137
[#117]: #117
[#129]: #129
[#130]: #130
[#122]: #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Madoshakalaka @davidpdrsn