Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert away from pkg_resources #175

Closed
matteius opened this issue Sep 10, 2022 · 5 comments
Closed

Convert away from pkg_resources #175

matteius opened this issue Sep 10, 2022 · 5 comments

Comments

@matteius
Copy link

I was working on converting pipenv away from pkg_resources to use instead distributions from https://docs.python.org/3/library/importlib.metadata.htmland in the past hour it became problematic because we rely on pipdeptree which is expecting we are working with pkg_resources Distriubtions. The problem as I see it is the pkg_resources documentation https://setuptools.pypa.io/en/latest/pkg_resources.html has this attention marker:

Attention

Use of pkg_resources is discouraged in favor of importlib.resources, importlib.metadata, and their backports (importlib_resources, importlib_metadata). Please consider using those libraries instead of pkg_resources

I started working on this in the first place because of some edge case where some users cannot import pkg_resources. Are there any plans to convert away from pkg_resources in this project?

@xiacunshun
Copy link
Collaborator

I noticed that there are also some pkg_resources used in source.
I think this need to be continued.

@gaborbernat
Copy link
Member

PR for this is welcome 😊

@xiacunshun
Copy link
Collaborator

#333

@xiacunshun
Copy link
Collaborator

xiacunshun commented Mar 15, 2024

I have submitted the code for this part, and due to API changes, the results may vary. I still have some unresolved issues, but I've gone ahead and submitted it first. Please help me with a code review if you have time, thank you. @gaborbernat

@kemzeb
Copy link
Collaborator

kemzeb commented Apr 2, 2024

Fixed by #333.

@kemzeb kemzeb closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants