Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 #2032

Closed
tirkarthi opened this issue Apr 17, 2021 · 5 comments

Comments

@tirkarthi
Copy link

Ref : python/cpython#25174

self._spinner_thread.setDaemon(True)

@jugmac00
Copy link
Member

Thank you for the notice.

@tirkarthi, do you want to create a pull request?

@tirkarthi
Copy link
Author

Sure, created #2033 . Since this was a simple change I was not sure if this needs a news entry. Please let me know if one is needed.

@jugmac00
Copy link
Member

Thank you! As this is no user-facing change, a changelog entry is not necessary.

If you want, you can add yourself to the list of contributors:
https://github.com/tox-dev/tox/blob/master/CONTRIBUTORS

@tirkarthi
Copy link
Author

Thanks, added myself.

@jugmac00
Copy link
Member

fixed by #2033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants