Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a worker for pngquant. #32

Closed
wants to merge 5 commits into from
Closed

Add a worker for pngquant. #32

wants to merge 5 commits into from

Conversation

adammathys
Copy link
Contributor

Simple implementation of the worker for pngquant. I noticed there was interest in issue #14 so I figured I'd submit a pull-request in case you'd like to use this as a starting point.

@toy
Copy link
Owner

toy commented Feb 4, 2014

Thanks for a good starting point.
I'll try to have a look soon.

@LeonB
Copy link

LeonB commented Jul 28, 2014

Any progress on this point? Is there something we can do?

@adammathys
Copy link
Contributor Author

Sorry, I had all but forgotten about this pull-request. I've rebased it against master, is there anything you'd like me to change or add @toy?

@kaspergrubbe
Copy link
Contributor

Does it make sense to take Pngquants --quality parameter into account? And what does it default to?

The source contains an extension. Need to account for that and remove it
when looking for the optimized image.
@toy
Copy link
Owner

toy commented Aug 5, 2014

@adammathys @LeonB @kaspergrubbe Sorry for such a long wait, I am working on this now.
I'll check which parts of code to use from this pull request and from #40. I will change two important things:

  1. There is an --output argument in pngquant starting from version 2.
  2. --quality must be used as default value will give lossy conversion instead of skipping worker for images with more than 256 colours. Quality for pngquant can be specified in multiple forms (M, -M, N- and N-M), but I am thinking of an option allowing only explicit range or two options for min and max values.

@toy
Copy link
Owner

toy commented Aug 8, 2014

@adammathys @LeonB @kaspergrubbe Please have a look at #52

@toy toy closed this Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants