Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #786

Conversation

williamcroberts
Copy link
Member

type is a bash builtin, use it over which is not always installed and
missing from the dependency list anyways.

Fixes: #785

Signed-off-by: William Roberts william.c.roberts@intel.com

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #786 (ac9e46f) into master (f0a0b80) will decrease coverage by 1.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   81.32%   79.62%   -1.70%     
==========================================
  Files          32       32              
  Lines        3721     3721              
==========================================
- Hits         3026     2963      -63     
- Misses        695      758      +63     
Impacted Files Coverage Δ
src/resource-manager-session.c 32.22% <0.00%> (-38.89%) ⬇️
src/session-entry-state-enum.c 64.70% <0.00%> (-11.77%) ⬇️
src/tpm2-command.c 64.37% <0.00%> (-2.84%) ⬇️
src/resource-manager.c 77.73% <0.00%> (-2.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a0b80...ac9e46f. Read the comment docs.

@williamcroberts williamcroberts force-pushed the use-type-over-which branch 2 times, most recently from 2c778df to 9b9645c Compare July 16, 2021 20:52
@williamcroberts williamcroberts changed the title configure: use type -p over which update dependencies Jul 16, 2021
William Roberts added 2 commits August 23, 2021 14:12
TSS now uses the git-describe for version so the master zip archive
provided by GitHub no longer works.

Signed-off-by: William Roberts <william.c.roberts@intel.com>
avoid an external dependency on which.

Which isn't always available, so use command

Signed-off-by: William Roberts <william.c.roberts@intel.com>
@flihp
Copy link
Contributor

flihp commented Dec 22, 2021

In #800 I took a different approach to getting rid of our sole use of 'which'. Using 'command' is better, but neither are necessary.

@flihp
Copy link
Contributor

flihp commented Dec 28, 2021

ec3e81c is outdated and has already been merged in 0821b0f.
ac9e46f is obsoleted by PR #800.
This PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlooked dependency: which
2 participants