From e3431ceca9122008bab93fa7d6576cb58992c031 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sat, 7 Sep 2024 13:50:25 -0700 Subject: [PATCH] test: reduce stack size for test-error-serdes Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error. remove test-error-serdes from flaky list move test-error-serdes to sequential PR-URL: https://github.com/nodejs/node/pull/54840 Refs: https://github.com/nodejs/node/issues/52630 Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow Reviewed-By: LiviaMedeiros Reviewed-By: Antoine du Hamel Reviewed-By: Trivikram Kamat --- test/parallel/parallel.status | 3 --- test/{parallel => sequential}/test-error-serdes.js | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) rename test/{parallel => sequential}/test-error-serdes.js (99%) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index e95b579e71da14..f47a42b7a4ccc2 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -16,9 +16,6 @@ test-worker-arraybuffer-zerofill: PASS, FLAKY # https://github.com/nodejs/node/issues/51862 test-fs-read-stream-concurrent-reads: PASS, FLAKY -# https://github.com/nodejs/node/issues/52630 -test-error-serdes: PASS, FLAKY - # Until V8 provides a better way to check for flag mismatch without # making the code cache/snapshot unreproducible, disable the test # for a preemptive check now. It should idealy fail more gracefully diff --git a/test/parallel/test-error-serdes.js b/test/sequential/test-error-serdes.js similarity index 99% rename from test/parallel/test-error-serdes.js rename to test/sequential/test-error-serdes.js index da09e6ed0a4d9f..bced9cf40b7326 100644 --- a/test/parallel/test-error-serdes.js +++ b/test/sequential/test-error-serdes.js @@ -1,4 +1,4 @@ -// Flags: --expose-internals +// Flags: --expose-internals --stack-size=64 'use strict'; require('../common'); const assert = require('assert');