Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No color option #6

Closed
Martoni opened this issue Nov 20, 2019 · 3 comments
Closed

No color option #6

Martoni opened this issue Nov 20, 2019 · 3 comments

Comments

@Martoni
Copy link
Contributor

Martoni commented Nov 20, 2019

Color output is great, but sometimes we need no color (for logging, old terminal, ...).
It could be good to add nocolor option.
@borovecek borovecek mentioned this issue Apr 27, 2020
Closed
@FFY00
Copy link

FFY00 commented Jul 9, 2020 •
edited
Loading

Deciding on outputting color based on isatty is usually enough, would that work for your use case?

@trabucayre
Copy link
Owner

I have added isatty, as mentioned by @FFY00, in display.cpp, to drop color when output is not a terminal.

It's good for you ?

@Martoni
Copy link
Contributor Author

Martoni commented Jul 15, 2020

seems to be good yes.

@Martoni Martoni closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Martoni @trabucayre @FFY00