Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github webhooks #26

Merged
merged 22 commits into from
Feb 7, 2024
Merged

Github webhooks #26

merged 22 commits into from
Feb 7, 2024

Conversation

dukris
Copy link
Collaborator

@dukris dukris commented Feb 1, 2024

@h1alexbel take a look, please
Closes #10


PR-Codex overview

Detailed summary

  • Added platforms section to application-web.yaml and application-pgit.yaml files.
  • Added github platform to application.yaml file.
  • Added dependencies for javax.json-api and gson in pom.xml.
  • Added package-info files for git.tracehub.pmo.platforms.github.webhook and git.tracehub.pmo.security.IpdTokenTest packages.
  • Updated ProjectController to create a webhook for Github projects.
  • Added integration tests for Webhooks and ExistsWebhook classes.
  • Added Webhook class to represent webhook content.

The following files were skipped due to too many changes: src/test/java/git/tracehub/pmo/platforms/github/webhook/WebhookTest.java, src/main/java/git/tracehub/pmo/platforms/github/webhook/ExistsWebhook.java, src/test/java/it/platforms/github/webhook/CreateWebhookIT.java, src/test/java/git/tracehub/pmo/platforms/github/webhook/ExistsWebhookTest.java, src/main/java/git/tracehub/pmo/platforms/github/webhook/Webhooks.java, src/main/java/git/tracehub/pmo/platforms/github/webhook/CreateWebhook.java, src/test/java/git/tracehub/pmo/platforms/github/webhook/WebhooksTest.java, src/test/java/git/tracehub/pmo/platforms/github/webhook/CreateWebhookTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1bc91b7) 53.00% compared to head (1fc8aff) 60.81%.
Report is 1 commits behind head on master.

Files Patch % Lines
...git/tracehub/pmo/controller/ProjectController.java 0.00% 5 Missing ⚠️
...tracehub/pmo/platforms/github/webhook/Webhook.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
+ Coverage     53.00%   60.81%   +7.81%     
- Complexity       48       59      +11     
============================================
  Files            20       24       +4     
  Lines           200      245      +45     
  Branches          6        7       +1     
============================================
+ Hits            106      149      +43     
- Misses           91       92       +1     
- Partials          3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dukris dukris requested a review from h1alexbel February 6, 2024 10:05
Copy link
Collaborator

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hizmailovich take a look, please

@dukris dukris requested a review from h1alexbel February 6, 2024 13:38
Copy link
Collaborator

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hizmailovich take a look, please

).exec();
new CreateWebhook(
this.host,
token,
location,
"url"
"url",
new ListOf<>("push")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use also labeled and opened for issues

@dukris dukris requested a review from h1alexbel February 7, 2024 08:48
@dukris
Copy link
Collaborator Author

dukris commented Feb 7, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 7, 2024

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit fa5ef9e into master Feb 7, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 7, 2024

@rultor merge

@hizmailovich Done! FYI, the full log is here (took me 2min)

@dukris dukris deleted the 10 branch February 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create webhook with selected types when project is registered
3 participants