Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Traceloop Init Flag: "Enabled/Disabled" #2366

Open
nirga opened this issue Dec 3, 2024 · 0 comments
Open

🐛 Bug Report: Traceloop Init Flag: "Enabled/Disabled" #2366

nirga opened this issue Dec 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nirga
Copy link
Member

nirga commented Dec 3, 2024

Description

Currently, OpenLLMetry initializes Traceloop instrumentation automatically without an explicit mechanism to enable or disable it. This behavior may not always align with user needs, such as in cases where instrumentation should be conditionally applied based on environment variables or runtime configurations.

Proposed Feature

Introduce a Traceloop Init Flag that allows users to explicitly enable or disable the instrumentation during initialization. This flag will give users greater control over when Traceloop's features are active in their environment.

Expected Behavior

  • A new configuration option (e.g., enabled: true/false) is added to the initialization API or configuration file.
  • When enabled is set to false, Traceloop instrumentation is skipped.
  • Default behavior should maintain backward compatibility, with the flag set to true by default if not explicitly specified.

Implementation Details

  1. Add a new enabled flag in the configuration interface.
  2. Update the initialization logic to check the flag before enabling instrumentation.
  3. Write unit tests to ensure proper behavior with the flag set to true and false.
  4. Update documentation to include details about the new flag.

Use Case

  • Development Environments: Developers may want to disable instrumentation in local setups for faster debugging.
  • Production Flexibility: Conditional instrumentation can improve performance or meet specific deployment needs.

Impact on Current Users

This change is backward-compatible as the default behavior will continue enabling instrumentation unless the flag is explicitly set to false.

@nirga nirga changed the title 🐛 Bug Report: 🐛 Bug Report: Traceloop Init Flag: "Enabled/Disabled" Dec 3, 2024
@dosubot dosubot bot added the bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant