Downgrade to stable Starknet version #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
luccamordente
commented
May 16, 2024
luccamordente
commented
- v6 is considered "Next"
- Downgrading to v5
This is in preparation for being able to withdraw funds from Paradex. * `getSocializedLossFactor`: Get the current socialized loss factor from the Paraclear contract. * `getReceivableAmount`: Given a withdrawal amount, calculate the final amount that will be received depending on the socialized loss factor.
* v6 is considered "Next" * Downgrading to v5
amayvs
approved these changes
May 16, 2024
|
@luccamordente @amayvs Yep, Starkware team says it is okay to use The only reason why Starkware does not release v6 as stable major due to some wallets still need to update (they say v6 goes live as early as 1-2 weeks~) ref: starknet-io/starknet.js#1040 (comment) |
SergeyVolynkin
approved these changes
May 17, 2024
@SergeyVolynkin I propose we upgrade when v6 is officially released so we can see the docs for breaking changes and do a more extensive testing. For now we know v5 works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.