Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawSeriesPointMarkers function does not work correctly #1755

Closed
ArtemIbs opened this issue Dec 13, 2024 · 1 comment
Closed

drawSeriesPointMarkers function does not work correctly #1755

ArtemIbs opened this issue Dec 13, 2024 · 1 comment
Labels
bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors.

Comments

@ArtemIbs
Copy link

Lightweight Charts™ Version: 4.2.2

Steps/code to reproduce:

  1. Add two series of data (one must start later than the other)
  2. Add pointMarkersVisible = true for shorter series
  3. Scroll until the shorter series goes out of view

Actual behavior:

Black fill appears

Expected behavior:

Black fill does not appears

Screenshots:

lightweight-charts.mov

JSFiddle link:

https://jsfiddle.net/x9yh56qm/

I think this behavior occurs because the drawSeriesPointMarkers function always does context.fill(), even if the series is out of scope

@illetid illetid added bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors. labels Dec 13, 2024
@illetid
Copy link
Contributor

illetid commented Jan 2, 2025

Hi @ArtemIbs, thanks for submitting the issue. The fix will be a part of the v5 release, which will be released soon

@illetid illetid closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors.
Projects
None yet
Development

No branches or pull requests

2 participants