Make --timeout use seconds

[smoelius]

      --timeout <TIMEOUT>     Number of milliseconds to consider a hang when fuzzing or replaying
                              (equivalent to -- -t <TIMEOUT> when fuzzing)

AFLplusplus's -V option uses seconds, as do libfuzzer's --timeout and --max_total_time options, and it's hard to keep the distinction.

Also, the extra granularity probably isn't necessary.

[dhruvdabhi101]

Hello, I am rust beginner. And I think I found the change i need to make to fix this issue. So can you please assign this issue to me ?

I have to just change

- Duration::from_millies 
+ Duration::from_secs

and also some changes where i need to change from 1000 to 1 because of conversion from millisecs to secs.

[smoelius]

@dhruvdabhi101 Thanks very much for your interest. I've assigned the issue to you.

One other location that I want to call out as needing to change is this one:

test-fuzz/cargo-test-fuzz/src/lib.rs

Line 945 in 49843b3

args.extend(["-t".to_owned(), format!("{}", timeout * NANOS_PER_MILLI)]);

Incidentally, I think there is a bug there. 😬 afl-fuzz expects its -t argument to be in milliseconds, not nanos:

  -t msec       - timeout for each run (auto-scaled, default 1000 ms). Add a '+'

So I think that line should probably be:

 args.extend(["-t".to_owned(), format!("{}", timeout)]); 

But following your changes, it will be something like:

 args.extend(["-t".to_owned(), format!("{}", timeout * MILLIS_PER_SEC)]);