Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watched items (episodes) #351

Open
mlaggner opened this issue Jun 2, 2022 · 3 comments
Open

watched items (episodes) #351

mlaggner opened this issue Jun 2, 2022 · 3 comments
Labels
Feature Request New feature or request In Progress We're working on it :)

Comments

@mlaggner
Copy link

mlaggner commented Jun 2, 2022

I have a problem with the endpoint /sync/watched/shows with episodes which are not in the same order as in trakt.tv (aired vs. dvd order for example).

When you sync your local watched state to trakt.tv, you can use the endpoint /sync/history along with the episodes key (and using the IDs from the episode rather than season/episode number) -> this works as expected

But when you sync the trakt.tv watched state to your local library, you only have the endpoint /sync/watched/shows which offers the watched state of your episodes in the trakt.tv order (via seasons -> episodes). Here are no IDs sent to the caller where we could do an ID lookup.

Lets assume we have the TV show Firefly in DVD order where the first episode is Serenity (https://thetvdb.com/series/firefly/episodes/297999) but in aired/trakt.tv order this is The Train Job (https://thetvdb.com/series/firefly/seasons/official/1). When calling the endpoint /sync/watched/shows the watched state from The Train Job (offered in the response as S01E01) gets synced to the local episode which is Serenity (S01E01 in DVD order).

Possible solutions? you could offer an own endpoint to get all watched episodes - e.g. /sync/watched/shows - which offers the IDs of the episodes too (like you already offer in /sync/history), so we can match the episodes by ourselves via the episode IDs

@rectifyer
Copy link
Contributor

Good point and I will look into this more, possible with an extended param on that method.

The workaround for now would be to get the seasons + episodes for the show, then do a local comparison of the episode number. That would find the complete episode object with IDs.

@rectifyer rectifyer added Feature Request New feature or request In Progress We're working on it :) labels Jun 2, 2022
@myron0815
Copy link

hejj... is there any update on this?
Matching by ID ootb would be really helpful :)

Thanks for the great work!

@michaldrabik
Copy link

michaldrabik commented Oct 1, 2023

@rectifyer May I also ask If there is any progress on adding IDs of episodes with extended param here? What also could help is always including all the episodes but with plays: 0 and last_watched_at null or gone. In case episode has not yet been watched.

I'm asking because recently I discovered that due to season/number combo and possibility of it changing there is a chance of constantly spamming Trakt account with new plays.

This is because since the episodes that are not watched are not included in the response at all - it is not clear if the episode is actually unwatched or something happened in the season/number data in the meantime.

Example:

  • user had S02 E12 marked as watched
  • something was wrong the S02 E12 is actually S03 E01 and S02 had only 11 eps. This is the same episode though, just wrong listing.
  • this gets fixed and updated on the server
  • locally when fetching from /sync/watched/shows the S02 E12 is gone but there is no way of veryfing without ID.

Thanks for any updates on that : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request In Progress We're working on it :)
Projects
None yet
Development

No branches or pull requests

4 participants