Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError: No module named 'prometheus_ecs_discoverer #15

Open
lado936 opened this issue Oct 5, 2021 · 8 comments
Open

ModuleNotFoundError: No module named 'prometheus_ecs_discoverer #15

lado936 opened this issue Oct 5, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@lado936
Copy link

lado936 commented Oct 5, 2021

Just tried to run project using docker on ECS and i am getting this error:
Error while finding module specification for 'prometheus_ecs_discoverer.main' (ModuleNotFoundError: No module named 'prometheus_ecs_discoverer

@lado936 lado936 changed the title Error while finding module specification for 'prometheus_ecs_discoverer.main' (ModuleNotFoundError: No module named 'prometheus_ecs_discoverer ModuleNotFoundError: No module named 'prometheus_ecs_discoverer Oct 5, 2021
@ZyanKLee
Copy link

ZyanKLee commented Oct 7, 2021

I got the same issue - did you find a solution? In the meantime I reverted to 3.2.1 which does not have this error.

@trallnag
Copy link
Owner

trallnag commented Oct 7, 2021

I will take a look at it this evening, thanks for raising the issue

@lado936
Copy link
Author

lado936 commented Oct 7, 2021

I got the same issue - did you find a solution? In the meantime I reverted to 3.2.1 which does not have this error.

3.3.3 is working fine, but version above that has module issue.

@trallnag
Copy link
Owner

trallnag commented Oct 7, 2021

@lado936, @ZyanKLee, have you considered using teralytics/prometheus-ecs-discovery? I initially created this tool here because I needed a few features the other ones did not provide. Now I'm not using PromED actively anymore (though an older version is still being used in a former team I worked with)

I still want to write another similar tool in Go that leverages AWS CloudMap for learning purposes. Would be much simpler than both PromED and teralytics/prometheus-ecs-discovery.

Nevertheless I will yank the broken releases, images, and packages and look when I get to fix the underlying issue

@trallnag trallnag added the bug Something isn't working label Oct 7, 2021
@ZyanKLee
Copy link

ZyanKLee commented Oct 8, 2021

Hello @trallnag ,
Thanks for looking into this issue. I had a look at teralytics' version in the past - there still is a feature request open that I require but they sadly had not had the time to do this yet: teralytics/prometheus-ecs-discovery#55

One question that came to my mind about the CloudMap: did you look at how using a CloudMap would change API cost?

Aside from that I like the idea.

@lado936
Copy link
Author

lado936 commented Oct 8, 2021

@trallnag the only reason i am not using that one is that they have no support for dynamic port discovery, i am creating services with random port and cant set static port in labels, i found one merge request which added dynamic port dyscovery but was not able to make it work on my setup

@EAlf91
Copy link

EAlf91 commented Mar 31, 2023

@lado936, @ZyanKLee, have you considered using teralytics/prometheus-ecs-discovery? I initially created this tool here because I needed a few features the other ones did not provide. Now I'm not using PromED actively anymore (though an older version is still being used in a former team I worked with)

I still want to write another similar tool in Go that leverages AWS CloudMap for learning purposes. Would be much simpler than both PromED and teralytics/prometheus-ecs-discovery.

Nevertheless I will yank the broken releases, images, and packages and look when I get to fix the underlying issue

Hey @trallnag In my team I recently stumbled upon the teralytics project as well. I'm pretty new to this topic but it seems any project is not being used or maintained anymore. Is there a shift in how to deal with discovering ecs tasks these days. I read about aws Service Connect and cloudmap and docs but it seems I'm missing some point here.

I'm just generally curious how to deal with this in 2023 on aws ecs 😃

@trallnag
Copy link
Owner

Hey @EAlf91, this tool sounds like what I was thinking about back when I made that comment: https://github.com/awslabs/aws-cloudmap-prometheus-sd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants