-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FastAPI in favor of Starlette #280
Comments
When I was looking for an instrumentation for starlette, I knew about this package and now I am also wondering if I can just throw a Starlette app at it. I'll give it a try! |
@chbndrhnns atm, I've been using my branch https://github.com/mvanderlee/prometheus-starlette-instrumentator/tree/no-fastapi requirements.txt
setup.py
|
We have FastAPI installed anyway for another use case so it seems I am good to way with this version here, as well. Thanks for the link, though! |
This project imports FastAPI simply to provide type hints. Moreover the middleware's function isn't limited to FastAPI and works fine with any Starlette implementation.
It'd be great if all code references to FastAPI could be replaced with Starlette.
The text was updated successfully, but these errors were encountered: