Any reason why the very similar function reset_prometheus is copy&pasted multiple times in your tests?

[petarmaric]

Let's say that the canonical version is here:

prometheus-fastapi-instrumentator/tests/helpers/utils.py

Lines 16 to 28 in c0813de

	# Unregister all collectors.
	collectors = list(REGISTRY._collector_to_names.keys())
	print(f"before unregister collectors={collectors}")
	for collector in collectors:
	REGISTRY.unregister(collector)
	# Import default collectors.
	from prometheus_client import gc_collector, platform_collector, process_collector
	# Re-register default collectors.
	process_collector.ProcessCollector()
	platform_collector.PlatformCollector()
	gc_collector.GCCollector()

I see pretty much the same code again in other test files, such as:

• prometheus-fastapi-instrumentator/tests/test_expose.py

  Lines 61 to 74 in c0813de

  	# Unregister all collectors.
  	collectors = list(REGISTRY._collector_to_names.keys())
  	print(f"before unregister collectors={collectors}")
  	for collector in collectors:
  	REGISTRY.unregister(collector)
  	print(f"after unregister collectors={list(REGISTRY._collector_to_names.keys())}")
  	# Import default collectors.
  	from prometheus_client import gc_collector, platform_collector, process_collector
  	# Re-register default collectors.
  	process_collector.ProcessCollector()
  	platform_collector.PlatformCollector()
  	gc_collector.GCCollector()

• prometheus-fastapi-instrumentator/tests/test_instrumentation.py

  Lines 26 to 39 in c0813de

  	# Unregister all collectors.
  	collectors = list(REGISTRY._collector_to_names.keys())
  	print(f"before unregister collectors={collectors}")
  	for collector in collectors:
  	REGISTRY.unregister(collector)
  	print(f"after unregister collectors={list(REGISTRY._collector_to_names.keys())}")
  	# Import default collectors.
  	from prometheus_client import gc_collector, platform_collector, process_collector
  	# Re-register default collectors.
  	process_collector.ProcessCollector()
  	platform_collector.PlatformCollector()
  	gc_collector.GCCollector()

• prometheus-fastapi-instrumentator/tests/test_instrumentator_expose.py

  Lines 15 to 28 in c0813de

  	# Unregister all collectors.
  	collectors = list(REGISTRY._collector_to_names.keys())
  	print(f"before unregister collectors={collectors}")
  	for collector in collectors:
  	REGISTRY.unregister(collector)
  	print(f"after unregister collectors={list(REGISTRY._collector_to_names.keys())}")
  	# Import default collectors.
  	from prometheus_client import gc_collector, platform_collector, process_collector
  	# Re-register default collectors.
  	process_collector.ProcessCollector()
  	platform_collector.PlatformCollector()
  	gc_collector.GCCollector()

[FaridFArab]

It needs to be refactored. I will work on it. Thanks for your announcing.