-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qtype_coderunner seems to ignore no_proxy list from moodle #178
Comments
Sorry, but I don't think I can be of much help, here. I've never configured Moodle with a proxy server.
CodeRunner uses the Moodle cURL class, which in turn uses PHP cURL. Moodle 4 has certainly made changes to the security around HTTP requests and I have had to tweak settings in Site administration General > Security > HTTP Security when, for example, running containerised Moodle and/or Jobe. So you should at least check those settings, though they don't seem to explain your situation.
For what it's worth, if you're using the latest CodeRunner and the HTTP Security settings are blocking access to Jobe, you should see an error message "URL is blocked" rather than just a timeout and/or a more generic 'something went wrong with jobe' type of error.
If you can't find a solution, I suggest you post to a Moodle forum on networking. I'm no networking guru.
Richard
…________________________________
From: Sven ***@***.***>
Sent: Saturday, 23 September 2023 6:36 am
To: trampgeek/moodle-qtype_coderunner ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [trampgeek/moodle-qtype_coderunner] qtype_coderunner seems to ignore no_proxy list from moodle (Issue #178)
We are running Moodle inside of our institutional private network. All outgoing traffic from moodle application servers (update checks, language file download and so on) has to go through our institutional proxy. We also have defined an exclusion list for internal hosts on the same network which are/should be reached directly.
The jobe server accepts requests only from the moodle application servers directly to restrict access.
This concept worked fine until we upgraded Moodle to 4.1 (from 3.11) and coderunner from 2022061500 to 2023090800.
Now Moodle can't reach the jobe server anymore because it tries to use the defined proxy.
I cross checked this.
First I disabled the proxy setting - coderunner can connect to jobe.
Second I enabled the proxy again but allowed access from the proxy to jobe - coderunner can connect to jobe.
So it seems there must be some change to how the proxy settings are used?
I also cross checked it against an older test system with Moodle 3.11 and coderunner 2022061500, here the proxy ignore list is used.
—
Reply to this email directly, view it on GitHub<#178>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIM2VW5JKNNWLBWK5HNCETX3XLCLANCNFSM6AAAAAA5DPSYKQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
This email may be confidential and subject to legal privilege, it may not reflect the views of the University of Canterbury, and it is not guaranteed to be virus free. If you are not an intended recipient, please notify the sender immediately and erase all copies of the message and any attachments.
|
In the latest version (5.2.4) I've changed the code to accept HTTP return codes of 201 through 204 as well as the usual 200. I understand some proxy servers change the return code from 200 to one of those codes when passing back a response. Could that be the cause of your problems? |
I can confirm that we have the same issue as @slaudel. In our constellation, there is an outbound squid proxy that has to be used for every outbound communication. Moodle uses this outbound proxy for updating language packs or other data. Maik |
We are running Moodle inside of our institutional private network. All outgoing traffic from moodle application servers (update checks, language file download and so on) has to go through our institutional proxy. We also have defined an exclusion list for internal hosts on the same network which are/should be reached directly.
The jobe server accepts requests only from the moodle application servers directly to restrict access.
This concept worked fine until we upgraded Moodle to 4.1 (from 3.11) and coderunner from 2022061500 to 2023090800.
Now Moodle can't reach the jobe server anymore because it tries to use the defined proxy.
I cross checked this.
First I disabled the proxy setting - coderunner can connect to jobe.
Second I enabled the proxy again but allowed access from the proxy to jobe - coderunner can connect to jobe.
So it seems there must be some change to how the proxy settings are used?
I also cross checked it against an older test system with Moodle 3.11 and coderunner 2022061500, here the proxy ignore list is used.
The text was updated successfully, but these errors were encountered: