Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtype_coderunner seems to ignore no_proxy list from moodle #178

Open
slaudel opened this issue Sep 22, 2023 · 3 comments
Open

qtype_coderunner seems to ignore no_proxy list from moodle #178

slaudel opened this issue Sep 22, 2023 · 3 comments

Comments

@slaudel
Copy link

slaudel commented Sep 22, 2023

We are running Moodle inside of our institutional private network. All outgoing traffic from moodle application servers (update checks, language file download and so on) has to go through our institutional proxy. We also have defined an exclusion list for internal hosts on the same network which are/should be reached directly.

The jobe server accepts requests only from the moodle application servers directly to restrict access.
This concept worked fine until we upgraded Moodle to 4.1 (from 3.11) and coderunner from 2022061500 to 2023090800.

Now Moodle can't reach the jobe server anymore because it tries to use the defined proxy.

I cross checked this.
First I disabled the proxy setting - coderunner can connect to jobe.
Second I enabled the proxy again but allowed access from the proxy to jobe - coderunner can connect to jobe.

So it seems there must be some change to how the proxy settings are used?

I also cross checked it against an older test system with Moodle 3.11 and coderunner 2022061500, here the proxy ignore list is used.

@trampgeek
Copy link
Owner

trampgeek commented Sep 22, 2023 via email

@trampgeek
Copy link
Owner

In the latest version (5.2.4) I've changed the code to accept HTTP return codes of 201 through 204 as well as the usual 200. I understand some proxy servers change the return code from 200 to one of those codes when passing back a response. Could that be the cause of your problems?

@mstuehrenberg
Copy link

mstuehrenberg commented Aug 28, 2024

I can confirm that we have the same issue as @slaudel. In our constellation, there is an outbound squid proxy that has to be used for every outbound communication. Moodle uses this outbound proxy for updating language packs or other data.
On-campus servers are in a different net segment, so that the outbound proxy cannot connect to internal (on-campus) servers (HTTP return code would be 503 in this case) -- for these we use the proxybypass settings in Moodle (as an example, communication between our Moodle hosts and a worker node for the quiz archiver plugin via REST web services is configured this way and works without problems).
I've tested the qtype_coderunner plugin in both versions, 5.2.1 (2023090800) from the Moodle plugin directory and 5.3.0 from github -- the problem remains in both versions.
It would be great if the qtype_coderunner plugin would respect Moodle's proxybypass settings.

Maik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants