Examples update #1389

samuelayo · 2019-03-28T15:36:53Z

Added python flask example
Added node.js example

arturi · 2019-04-01T20:22:47Z

Thank you!

arturi · 2019-04-04T10:38:28Z

examples/node-xhr/server.js

+  if (req.url === '/upload' && req.method.toLowerCase() === 'post') {
+    // parse a file upload
+    var form = new formidable.IncomingForm()
+


Can we add an upload directory, like form.uploadDir = "./uploads"? Otherwise I ran this on mac and couldn’t figure out where the files went. And maybe also preserve the extension. So:

form.uploadDir = "./uploads" form.keepExtensions = true

Maybe we could add some logging, too, like here: https://stackoverflow.com/a/46973498

Added the upload dir and the logging. Also added one more example for PHP

kvz · 2019-04-09T11:32:22Z

examples/php-xhr/upload.php

@@ -0,0 +1,35 @@
+<?php
+ini_set('display_errors', 1);


No consistent indentation in this file

kvz · 2019-04-09T11:32:35Z

examples/php-xhr/upload.php

+ini_set('display_startup_errors', 1);
+error_reporting(E_ALL);
+
+if($_SERVER["REQUEST_METHOD"] == "OPTIONS")


Please use triple equality

kvz · 2019-04-09T11:32:47Z

examples/php-xhr/upload.php

+
+if($_SERVER["REQUEST_METHOD"] == "OPTIONS")
+{
+    if (isset($_SERVER["HTTP_ACCESS_CONTROL_REQUEST_METHOD"]))


please wrap if contents in {}

kvz · 2019-04-09T11:33:26Z

examples/php-xhr/upload.php

+    exit(0);
+}
+
+if($_POST) {


Maybe change to !empty($_FILES["files"])

kvz · 2019-04-09T11:33:49Z

examples/php-xhr/upload.php

+      if (move_uploaded_file($_FILES["files"]["tmp_name"][0], $target_file)) {
+        header("Access-Control-Allow-Origin: *");
+        header('Content-type: application/json');
+        $data = ["url" => $target_file, "message" => "The file ". basename( $_FILES["files"]["name"][0]). " has been uploaded."];


inconsistent whitespace regarding concatenation here

kvz · 2019-04-09T11:34:00Z

examples/php-xhr/upload.php

+        echo json_encode( $data );
+      } else {
+        header("Access-Control-Allow-Origin: *");
+        header('Content-type: application/json');


Mixing of single & double quotes

kvz · 2019-04-09T11:34:18Z

examples/php-xhr/upload.php

+        header('Content-type: application/json');
+        $data = ["message" => "Sorry, there was an error uploading your file."];
+        http_response_code(400);
+        echo json_encode( $data );


white space within parenthesis is new here

kvz · 2019-04-09T11:35:26Z

examples/php-xhr/upload.php

+      } else {
+        header("Access-Control-Allow-Origin: *");
+        header('Content-type: application/json');
+        $data = ["message" => "Sorry, there was an error uploading your file."];


More descriptive error would be good

Maybe I should use a try catch? and send the error array from the throwable?

Not sure if that works? I don't think it throws right? So maybe just sth like: Unable to move the uploaded file to its final location: X. Please check up on server permissions.

Yes it throws, using the throwable path. Not sure the move_uploaded_file function throws, as it returns a boolean. I can throw an error from the block when the boolean is false;

Updated it, I guess this way, if any other error that throws comes up, it is also handled

arturi · 2019-04-11T13:37:59Z

@samuelayo I updated all of the examples to use CSS from the bundle (otherwise we had a mismatch of CSS and JS), tweaked readmes and added uploads folder creation — without it all of the examples didn’t function for me (they errored when trying to write to uploads). Could you let me know if these changes make sense?

I wonder if we should not rely on uppy from the project and instead use the npm version in all those examples. That way you don’t have to run anything in the project root before it’s usable.

samuelayo · 2019-04-17T11:47:09Z

This makes sense @arturi. I also thing we should use the Uppy package from NPM. I'll update the examples to use uppy from NPM.

arturi · 2019-04-17T11:48:58Z

@samuelayo Problem with that is that it might be out of date with the current package, like after 6 months uppy is 1.3 and examples are 0.30.4, but we can update manually once in a while, I guess.

samuelayo · 2019-04-17T12:07:29Z

@arturi I think so. E.g updating the uppy version after every major release

kvz · 2019-04-17T14:15:10Z

@samuelayo Problem with that is that it might be out of date with the current package, like after 6 months uppy is 1.3 and examples are 0.30.4, but we can update manually once in a while, I guess.

This is what we have the 'version replacer' for

goto-bus-stop · 2019-04-17T14:23:08Z

examples/php-xhr/requirements.txt

@@ -0,0 +1,3 @@
+flask
+werkzeug
+flask-cors


probably an extraneous file? python-xhr and php-xhr both have a requirements.txt, should only be python i think?

Yes, thanks for noting this.

arturi · 2019-04-17T14:54:22Z

This is what we have the 'version replacer' for

it won’t replace package.json dependencies at the moment, or will it?

arturi · 2019-04-18T12:43:08Z

examples/node-xhr/package.json

@@ -21,6 +16,7 @@
    "cors": "^2.8.4",
    "formidable": "^1.2.1",
    "npm-run-all": "^4.1.3",
-    "rimraf": "^2.6.2"
+    "rimraf": "^2.6.2",
+    "uppy": "^0.30.4"
  }


I wonder if we need to add each individual uppy module instead of a bundle thing. So like @uppy/core, @uppy/xhr-upload etc.

samuelayo added 5 commits March 28, 2019 15:30

add node xhr example

d3e6702

add python example with flask

41ee14d

change example name

b9a0fe7

change example name for node and commit node

d294498

update readme

64b7f78

arturi reviewed Apr 4, 2019

View reviewed changes

samuelayo added 3 commits April 8, 2019 23:47

Add PHP example, also update node example to log out

8ee50e4

Update index.html

b2f467a

Merge branch 'master' into examples_update

2b65ff2

kvz reviewed Apr 9, 2019

View reviewed changes

examples/php-xhr/upload.php

@@ -0,0 +1,35 @@

<?php

ini_set('display_errors', 1);

Copy link

Member

kvz Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No consistent indentation in this file

kvz reviewed Apr 9, 2019

View reviewed changes

examples/php-xhr/upload.php Outdated

exit(0);

}

if($_POST) {

Copy link

Member

kvz Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to !empty($_FILES["files"])

kvz reviewed Apr 9, 2019

View reviewed changes

samuelayo and others added 5 commits April 9, 2019 12:47

Update upload.php

8c20298

Change if/else to try catch

39af08c

update header for allow headers

1601171

Update upload.php

2ad6f52

create uploads folder, use uppy css from the bundle

d1e621c

goto-bus-stop reviewed Apr 17, 2019

View reviewed changes

change from bundle to node_modules

eb1597f

Merge branch 'master' into examples_update

1e79a6d

arturi reviewed Apr 18, 2019

View reviewed changes

arturi merged commit 3a2dca2 into master Apr 19, 2019

arturi deleted the examples_update branch April 19, 2019 10:04

H4NG-MAN mentioned this pull request Sep 25, 2022

[Snyk] Fix for 8 vulnerabilities H4NG-MAN/uppy#119

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Examples update #1389

Examples update #1389

samuelayo commented Mar 28, 2019

arturi commented Apr 1, 2019

arturi Apr 4, 2019

arturi Apr 4, 2019

samuelayo Apr 8, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

kvz Apr 9, 2019

samuelayo Apr 9, 2019

kvz Apr 9, 2019

samuelayo Apr 9, 2019

samuelayo Apr 9, 2019

arturi commented Apr 11, 2019

samuelayo commented Apr 17, 2019

arturi commented Apr 17, 2019

samuelayo commented Apr 17, 2019

kvz commented Apr 17, 2019 •

edited

Loading

goto-bus-stop Apr 17, 2019

samuelayo Apr 17, 2019

arturi commented Apr 17, 2019

arturi Apr 18, 2019

Examples update #1389

Examples update #1389

Conversation

samuelayo commented Mar 28, 2019

arturi commented Apr 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arturi commented Apr 11, 2019

samuelayo commented Apr 17, 2019

arturi commented Apr 17, 2019

samuelayo commented Apr 17, 2019

kvz commented Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arturi commented Apr 17, 2019

Choose a reason for hiding this comment

kvz commented Apr 17, 2019 •

edited

Loading