Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion,google-drive: drop deprecated usage for Google Drive's "shared drive" #1846

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

ifedapoolarewaju
Copy link
Contributor

Google Drive API has deprecated the use of Team Drives, and replaced it with just Drives. This PR drops the deprecated implementation and adds the newly support implementation.

Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

For some reason this doesn't show the shared drive's icon anymore … previously:
image

Now:
image

The JSON doesn't include an icon property anymore.

@ifedapoolarewaju
Copy link
Contributor Author

For some reason this doesn't show the shared drive's icon anymore

@goto-bus-stop should be fixed now, thank you!

@goto-bus-stop
Copy link
Contributor

Hmm now Companion crashes for me when listing drives. I added a console.log to show the shape of the item object in getItemIcon:
image
I couldn't immediately figure out why it doesn't have a thumbnailImageLink :/

@ifedapoolarewaju ifedapoolarewaju merged commit 56eed5a into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the google-drive-shared-drive branch September 25, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants