New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EdDSA operation signing tests #276

Closed

OR13 opened this issue Nov 15, 2021 · 4 comments · Fixed by #361

Assignees

Member

OR13 commented Nov 15, 2021

These tests here use ES256K: https://github.com/transmute-industries/sidetree.js/blob/main/packages/did-method/src/__tests__/wallet.core.test.ts

https://github.com/transmute-industries/sidetree.js/blob/main/packages/test-vectors/src/did-method/v1-did-method-secp256k1-operations.json

We need too generate a new set of operations that use EdDSA using:

https://github.com/transmute-industries/sidetree.js/blob/main/packages/wallet/src/__test__/generate-operation-fixture.test.ts#L32 with "Ed25519" instead.

Member Author

OR13 commented Nov 15, 2021

@gjgd this was one of the issues we discussed.

Member Author

OR13 commented Jan 19, 2022

Last I checked this was blocked by ion sdk updates...

Looks like part of it was fixed here: decentralized-identity/ion-sdk@0af90f7

Member Author

OR13 commented Jan 19, 2022

Looks like its still blocked by IonKey inability to sign with EdDSA.

OR13 assigned gjgd

OR13 mentioned this issue

Support for other crypto algos? #130

Closed

Contributor

gjgd commented Jan 19, 2022

I'm slowly working on Part 2/2, pretty busy atm. Should be done by this weekend

gjgd mentioned this issue

Ed25519 operation fixtures #361

Merged

gjgd closed this as completed in #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment