Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score Limit stopped working #46

Closed
jojubart opened this issue Jan 6, 2023 · 6 comments
Closed

Score Limit stopped working #46

jojubart opened this issue Jan 6, 2023 · 6 comments

Comments

@jojubart
Copy link

jojubart commented Jan 6, 2023

The score limit stopped working around 10 or so hours ago and all posts are coming into the feed unfiltered.

@trashhalo
Copy link
Owner

trashhalo commented Jan 6, 2023

Shoot. I merged a breaking change last night that renamed the field to scoreLimit would it be hard to change the urls of your feed to use the new name or I can revert to give everyone time to move over?

#45

In the future I wonder what a good way would be to communicate with the people that use this feed before changing stuff. 🤔

@jojubart
Copy link
Author

jojubart commented Jan 6, 2023

Ah no worries I'll change my feed, thanks a lot for all the work!

I'll head to this repo as soon as I notice any breaks like today - so maybe if you put a section in the README about recent breaking changes and how the users can adapt could be good? :)

@butter-radish
Copy link

In the future I wonder what a good way would be to communicate with the people that use this feed before changing stuff.

Like the other user said, I think mentioning breaking changes prominently on the README here for a while should be fine. This GitHub repo is where every user of the application and the instance you host will come for support, and the people who still use the service (and the rate limit) will definitely come here in the next couple days when they notice the issue; and all issues going forward.

@notDavid
Copy link

notDavid commented Jan 7, 2023

In the future I wonder what a good way would be to communicate with the people that use this feed before changing stuff

Perhaps you could enable "Releases" for this repo, because people can then subscribe to those and will get notified of new versions / changelogs automatically.
Then, you can list future "breaking changes" in the release description.

Random example: https://github.com/go-gitea/gitea/releases and then click Watch > Custom > Releases.

@glottisfaun0000
Copy link

so many broken feeds...🥲

@trashhalo
Copy link
Owner

💥 #47

You can now follow https://github.com/trashhalo/reddit-rss/discussions/categories/announcements.atom on your feed reader to get announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants